Do not dump stats for read only engines' tables. - #5508
Merged
Conversation
spetrunia
approved these changes
Aug 7, 2026
spetrunia
left a comment
spetrunia
left a comment
Member
There was a problem hiding this comment.
Please also mention in the comment that we should not save or try to restore const rows.
Ok to push after that.
Stats for tables from engines such as Archive, S3, PerfSchema, and Sequence shouldn't be recorded in the context. Similarly, const row records should also not be stored in the context. Added few tests for Sequence's engine tables like seq_1_to_5.
bsrikanth-mariadb
force-pushed
the
bb-13.2-do-not-dump-stats-for-read-only-engine-tables
branch
from
August 7, 2026 08:40
b71c995 to
2a27240
Compare
bsrikanth-mariadb
merged commit Aug 7, 2026
2a27240
into
bb-12.3-MDEV-39368-test-replay-preview-tree
13 of 20 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stats for tables from engines such as Archive, S3, PerfSchema, and
Sequence shouldn't be recorded in the context. Similarly, const row
records should also not be stored in the context.
Added few tests for Sequence's engine tables like seq_1_to_5.