MDEV-40168 wip - #5620
Draft
mariadb-YuchenPei wants to merge 2 commits into
Draft
Conversation
|
|
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
2 times, most recently
from
September 1, 2026 06:51
8a9c029 to
21cf57e
Compare
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 1, 2026 07:51
21cf57e to
d3452c7
Compare
spetrunia
self-requested a review
September 1, 2026 09:05
spetrunia
reviewed
Sep 1, 2026
| t1 CREATE TABLE `t1` ( | ||
| `c` int(11) DEFAULT NULL, | ||
| `j` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_bin DEFAULT NULL CHECK (json_valid(`j`)) | ||
| ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci |
Member
There was a problem hiding this comment.
So, the index is now shown in SHOW CREATE TABLE ?
Member
There was a problem hiding this comment.
rather is NOT shown in SHOW CREATE TABLE
spetrunia
reviewed
Sep 1, 2026
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 1, 2026 10:09
d3452c7 to
7cfaf2b
Compare
spetrunia
reviewed
Sep 2, 2026
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
4 times, most recently
from
September 3, 2026 07:45
344ad21 to
08d0e46
Compare
spetrunia
reviewed
Sep 3, 2026
Member
|
For the record: index is not visible in information_schema: create table t25 (
js json,
key idx ((CAST(json_extract(js, '$.tags') AS CHAR(6) ARRAY)))
)engine=innodb;
select * from information_schema.statistics where table_name='t25'gives nothing. |
Member
|
And this crashes: create table t25 (
js json,
key idx ((CAST(json_extract(js, '$.tags') AS CHAR(6) ARRAY)))
)engine=innodb;
insert into t25 values ('{}'); |
Contributor
Author
Isn't this the same problem as your other comment #5620 (comment)? |
TODOs on top of those in the patch diff: - EXPLAIN output should not say fulltext - check type match to avoid false negative / positive bugs in mysql - transcode the value into the index charset in mvi_encode_key
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 4, 2026 01:49
6ff4ac9 to
78f3529
Compare
Contributor
Author
Fixed now |
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 4, 2026 06:35
e7ff23f to
d14f631
Compare
mariadb-YuchenPei
force-pushed
the
bb-main-mdev-40168
branch
from
September 4, 2026 07:06
d14f631 to
2b86847
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs on top of those in the patch diff: