feat: option to correct sideways scans - #8103
Merged
david-yz-liu merged 7 commits intoAug 6, 2026
Merged
Conversation
Collaborator
Coverage Report for CI Build 30970627726Coverage increased (+0.02%) to 90.604%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
YheChen
requested review from
david-yz-liu
and removed request for
david-yz-liu
August 4, 2026 02:07
david-yz-liu
reviewed
Aug 5, 2026
| upside_down: Page Upside Down? | ||
| rotate90_left: Rotate 90° left | ||
| rotate90_right: Rotate 90° right | ||
| rotation: Page Orientation |
Collaborator
There was a problem hiding this comment.
Change to "Fix Page Orientation"
|
|
||
| b. You'll be taken to a new screen where you can see the scanned page and text label, and input the copy number and page number. (The text label is in the form `<template name>-<copy number>-<page number>`.) | ||
| You can also specify if the page was scanned upside down, so that MarkUs will reorient the page when displaying it for graders. | ||
| You can also correct the page orientation before saving. |
Collaborator
There was a problem hiding this comment.
This is good; please also replace the screenshot below
| margin-top: 0.2em; | ||
| } | ||
|
|
||
| .rotation-button { |
Collaborator
There was a problem hiding this comment.
This is good; the icons are a bit off-centre, please modify the vertical-align property for this class to fix the centering.
david-yz-liu
approved these changes
Aug 6, 2026
david-yz-liu
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, @YheChen!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Fixes #7768
This change adds Rotate Page 90° right and Rotate Page 90° left arrow buttons to the scanned-exam error correction page. Each click immediately updates the PDF preview by 90°, and the resulting rotation is applied permanently when the corrected scan is saved.
Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)