Skip to content

feat: option to correct sideways scans - #8103

Merged
david-yz-liu merged 7 commits into
MarkUsProject:masterfrom
YheChen:feat/correct-sideways-scans
Aug 6, 2026
Merged

feat: option to correct sideways scans#8103
david-yz-liu merged 7 commits into
MarkUsProject:masterfrom
YheChen:feat/correct-sideways-scans

Conversation

@YheChen

@YheChen YheChen commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Fixes #7768

This change adds Rotate Page 90° right and Rotate Page 90° left arrow buttons to the scanned-exam error correction page. Each click immediately updates the PDF preview by 90°, and the resulting rotation is applied permanently when the corrected scan is saved.

Screenshots of your changes (if applicable) image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 30970627726

Coverage increased (+0.02%) to 90.604%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 41 of 41 lines across 3 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 51638
Covered Lines: 47804
Line Coverage: 92.58%
Relevant Branches: 2491
Covered Branches: 1239
Branch Coverage: 49.74%
Branches in Coverage %: Yes
Coverage Strength: 129.61 hits per line

💛 - Coveralls

@YheChen
YheChen requested review from david-yz-liu and removed request for david-yz-liu August 4, 2026 02:07
@YheChen YheChen changed the title feat: option to correct sideways scans WIP: feat: option to correct sideways scans Aug 4, 2026
@YheChen YheChen changed the title WIP: feat: option to correct sideways scans feat: option to correct sideways scans Aug 4, 2026
upside_down: Page Upside Down?
rotate90_left: Rotate 90° left
rotate90_right: Rotate 90° right
rotation: Page Orientation

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to "Fix Page Orientation"


b. You'll be taken to a new screen where you can see the scanned page and text label, and input the copy number and page number. (The text label is in the form `<template name>-<copy number>-<page number>`.)
You can also specify if the page was scanned upside down, so that MarkUs will reorient the page when displaying it for graders.
You can also correct the page orientation before saving.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good; please also replace the screenshot below

margin-top: 0.2em;
}

.rotation-button {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good; the icons are a bit off-centre, please modify the vertical-align property for this class to fix the centering.

@YheChen
YheChen requested a review from david-yz-liu August 5, 2026 03:17

@david-yz-liu david-yz-liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @YheChen!

@david-yz-liu
david-yz-liu merged commit 9ba2275 into MarkUsProject:master Aug 6, 2026
8 checks passed
@david-yz-liu david-yz-liu added this to the v2.10.2 milestone Aug 6, 2026
@YheChen
YheChen deleted the feat/correct-sideways-scans branch August 6, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have option to correct sideways scans

3 participants