Skip to content

v1.3.4 — legacy-strip critical fixes

Choose a tag to compare

View all tags
@MartinCastroAlvarez MartinCastroAlvarez released this 28 May 22:55
· 37 commits to main since this release
Immutable release. Only release title and notes can be modified.
v1.3.4
2cb02d5
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode.

v1.3.4 — legacy-strip critical fixes

Two shipped-and-broken bugs in the v1.3.x reverse banner — the legacy-side experience-toggle strip introduced in v1.2.0 — that took the feature out of production on the most common admin pages.

#595 — strip in the wrong template block

v1.2.0/v1.3.x injected the strip inside {% block content %}. Django's change_list.html, change_form.html, index.html, and login.html all override {% block content %} without {{ block.super }} — silently discarding the strip on every page a user actually visits.

Fixed by moving the strip into {% block header %} (defined once in admin/base.html, not overridden by any of those templates). The strip now renders consistently across the whole admin surface AND lands visually above the admin header — exactly where a migration-direction banner should be.

#596 — multi-line hash-form comment leaked as literal text

The legacy-side strip template had a multi-line {# … #} comment. Django's hash-form comments are single-line only — multi-line forms leak the opening + closing tokens onto the page as literal text.

Fixed by replacing with the block-form {% comment %}…{% endcomment %}. Bonus discovery captured in the comment itself: Django's block-comment lexer is a naive forward scan that closes on the first close-token it sees, including ones inside the comment body text — so the comment text deliberately avoids quoting the tag names verbatim.

Install

pip install --upgrade django-admin-react==1.3.4

PyPI: https://pypi.org/project/django-admin-react/1.3.4/

🤖 Generated with Claude Code

Assets 3
Loading