Skip to content

[repr types] Regression tests from reverted ColumnKnowledge#34905

Merged
mgree merged 1 commit intoMaterializeInc:mainfrom
mgree:repr-types-regression-tests
Feb 9, 2026
Merged

[repr types] Regression tests from reverted ColumnKnowledge#34905
mgree merged 1 commit intoMaterializeInc:mainfrom
mgree:repr-types-regression-tests

Conversation

@mgree
Copy link
Contributor

@mgree mgree commented Feb 4, 2026

#34858 reverted #34788, due to a variety of panics in a nightly run.

This PR adds the failures from those panics to an SLT file, for regression testing in a rewrite of the original PR.

Motivation

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@mgree mgree added C-bug Category: something is broken T-testing Theme: tests or test infrastructure A-optimization Area: query optimization and transformation labels Feb 4, 2026
@mgree mgree requested a review from ggevay February 9, 2026 15:02
@mgree mgree merged commit 35ab6bc into MaterializeInc:main Feb 9, 2026
12 checks passed
mgree added a commit to mgree/materialize that referenced this pull request Feb 9, 2026
…alizeInc#34905)

MaterializeInc#34858 reverted
MaterializeInc#34788, due to a
variety of panics in a nightly run.

This PR adds the failures from those panics to an SLT file, for
regression testing in a rewrite of the original PR.

### Motivation

  * This PR introduces regression tests for a recognized bug.
MaterializeInc/database-issues#10045
MaterializeInc/database-issues#10046
MaterializeInc/database-issues#10052
def- added a commit to def-/materialize that referenced this pull request Feb 10, 2026
Introduced by MaterializeInc#34905

Seen in https://buildkite.com/materialize/nightly/builds/15083

    Bail:test/sqllogictest/github-10045-10046-10052.slt:47 PlanFailure:test/sqllogictest/github-10045-10046-10052.slt:47:
    db error: ERROR: log source reads must target a replica
    DETAIL: The query references the following log sources:
        mz_compute_frontiers_per_worker
    HINT: Use `SET cluster_replica = <replica-name>` to target a specific replica in the active cluster. Note that subsequent queries will only be answered by the selected replica, which might reduce availability. To undo the replica selection, use `RESET cluster_replica`.
def- added a commit that referenced this pull request Feb 10, 2026
Introduced by #34905

Seen in https://buildkite.com/materialize/nightly/builds/15083

Bail:test/sqllogictest/github-10045-10046-10052.slt:47
PlanFailure:test/sqllogictest/github-10045-10046-10052.slt:47:
    db error: ERROR: log source reads must target a replica
    DETAIL: The query references the following log sources:
        mz_compute_frontiers_per_worker
HINT: Use `SET cluster_replica = <replica-name>` to target a specific
replica in the active cluster. Note that subsequent queries will only be
answered by the selected replica, which might reduce availability. To
undo the replica selection, use `RESET cluster_replica`.

Test run: https://buildkite.com/materialize/nightly/builds/15084

### Checklist

- [ ] This PR has adequate test coverage / QA involvement has been duly
considered. ([trigger-ci for additional test/nightly
runs](https://trigger-ci.dev.materialize.com/))
- [ ] This PR has an associated up-to-date [design
doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md),
is a design doc
([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)),
or is sufficiently small to not require a design.
  <!-- Reference the design in the description. -->
- [ ] If this PR evolves [an existing `$T ⇔ Proto$T`
mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md)
(possibly in a backwards-incompatible way), then it is tagged with a
`T-proto` label.
- [ ] If this PR will require changes to cloud orchestration or tests,
there is a companion cloud PR to account for those changes that is
tagged with the release-blocker label
([example](MaterializeInc/cloud#5021)).
<!-- Ask in #team-cloud on Slack if you need help preparing the cloud
PR. -->
- [ ] If this PR includes major [user-facing behavior
changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note),
I have pinged the relevant PM to schedule a changelog post.
mgree added a commit that referenced this pull request Feb 13, 2026
This PR combines two bugfixes to give the best fix, allowing for
multireplica tests.

### Motivation

#34966 fixes an SLT
test from #34905 that
broke in nightly when run with multiple replicas.

The fix there is better than the fix I put in
#34958, which forces
the test to only run in single replica mode.

### Description

Takes the `singlereplica_` out of the name, so we'll actually run
multi-replica tests.

### Verification

Running appropriate 4-replica slt tests from nightly.
patrickwwbutler pushed a commit to patrickwwbutler/materialize that referenced this pull request Feb 19, 2026
…alizeInc#34905)

MaterializeInc#34858 reverted
MaterializeInc#34788, due to a
variety of panics in a nightly run.

This PR adds the failures from those panics to an SLT file, for
regression testing in a rewrite of the original PR.

### Motivation

  * This PR introduces regression tests for a recognized bug.
MaterializeInc/database-issues#10045
MaterializeInc/database-issues#10046
MaterializeInc/database-issues#10052
patrickwwbutler pushed a commit to patrickwwbutler/materialize that referenced this pull request Feb 19, 2026
…alizeInc#34905)

MaterializeInc#34858 reverted
MaterializeInc#34788, due to a
variety of panics in a nightly run.

This PR adds the failures from those panics to an SLT file, for
regression testing in a rewrite of the original PR.

### Motivation

  * This PR introduces regression tests for a recognized bug.
MaterializeInc/database-issues#10045
MaterializeInc/database-issues#10046
MaterializeInc/database-issues#10052
patrickwwbutler pushed a commit to patrickwwbutler/materialize that referenced this pull request Feb 19, 2026
…c#34966)

Introduced by MaterializeInc#34905

Seen in https://buildkite.com/materialize/nightly/builds/15083

Bail:test/sqllogictest/github-10045-10046-10052.slt:47
PlanFailure:test/sqllogictest/github-10045-10046-10052.slt:47:
    db error: ERROR: log source reads must target a replica
    DETAIL: The query references the following log sources:
        mz_compute_frontiers_per_worker
HINT: Use `SET cluster_replica = <replica-name>` to target a specific
replica in the active cluster. Note that subsequent queries will only be
answered by the selected replica, which might reduce availability. To
undo the replica selection, use `RESET cluster_replica`.

Test run: https://buildkite.com/materialize/nightly/builds/15084

### Checklist

- [ ] This PR has adequate test coverage / QA involvement has been duly
considered. ([trigger-ci for additional test/nightly
runs](https://trigger-ci.dev.materialize.com/))
- [ ] This PR has an associated up-to-date [design
doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md),
is a design doc
([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)),
or is sufficiently small to not require a design.
  <!-- Reference the design in the description. -->
- [ ] If this PR evolves [an existing `$T ⇔ Proto$T`
mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md)
(possibly in a backwards-incompatible way), then it is tagged with a
`T-proto` label.
- [ ] If this PR will require changes to cloud orchestration or tests,
there is a companion cloud PR to account for those changes that is
tagged with the release-blocker label
([example](MaterializeInc/cloud#5021)).
<!-- Ask in #team-cloud on Slack if you need help preparing the cloud
PR. -->
- [ ] If this PR includes major [user-facing behavior
changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note),
I have pinged the relevant PM to schedule a changelog post.
patrickwwbutler pushed a commit to patrickwwbutler/materialize that referenced this pull request Feb 19, 2026
…nc#34991)

This PR combines two bugfixes to give the best fix, allowing for
multireplica tests.

### Motivation

MaterializeInc#34966 fixes an SLT
test from MaterializeInc#34905 that
broke in nightly when run with multiple replicas.

The fix there is better than the fix I put in
MaterializeInc#34958, which forces
the test to only run in single replica mode.

### Description

Takes the `singlereplica_` out of the name, so we'll actually run
multi-replica tests.

### Verification

Running appropriate 4-replica slt tests from nightly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-optimization Area: query optimization and transformation C-bug Category: something is broken T-testing Theme: tests or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants