slt: Allow multireplica in github-10045-10046-10052.slt#34991
Merged
mgree merged 2 commits intoMaterializeInc:mainfrom Feb 13, 2026
Merged
slt: Allow multireplica in github-10045-10046-10052.slt#34991mgree merged 2 commits intoMaterializeInc:mainfrom
mgree merged 2 commits intoMaterializeInc:mainfrom
Conversation
Pre-merge checklist
|
5 tasks
def-
approved these changes
Feb 12, 2026
Contributor
def-
left a comment
def-
left a comment
There was a problem hiding this comment.
Test change is fine, I have less of an idea about src/transform!
mgree
force-pushed
the
allow-multireplica-in-10045etc
branch
from
ecfa549 to
c63c1e7
Compare
Contributor
Author
|
Oy! I don't know how that change even snuck in, it's supposed to be on a different local branch. Delighted it passed nightly (since #34858 reverted it), but it shouldn't have been in here. I'll re-run the 4-replica SLTs to be double sure that the change is good. |
patrickwwbutler
pushed a commit
to patrickwwbutler/materialize
that referenced
this pull request
Feb 19, 2026
…nc#34991) This PR combines two bugfixes to give the best fix, allowing for multireplica tests. ### Motivation MaterializeInc#34966 fixes an SLT test from MaterializeInc#34905 that broke in nightly when run with multiple replicas. The fix there is better than the fix I put in MaterializeInc#34958, which forces the test to only run in single replica mode. ### Description Takes the `singlereplica_` out of the name, so we'll actually run multi-replica tests. ### Verification Running appropriate 4-replica slt tests from nightly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines two bugfixes to give the best fix, allowing for multireplica tests.
Motivation
#34966 fixes an SLT test from #34905 that broke in nightly when run with multiple replicas.
The fix there is better than the fix I put in #34958, which forces the test to only run in single replica mode.
Description
Takes the
singlereplica_out of the name, so we'll actually run multi-replica tests.Verification
Running appropriate 4-replica slt tests from nightly.