Revert "storage-controller: respond to table appends before txn-wal aply (#37443)#37631
Merged
Conversation
…pply (MaterializeInc#37443)" This reverts commit 6c590b0. I tried to fix performance regression the change introduced in other benchmarks in MaterializeInc#37627, but failed.
ggevay
approved these changes
Jul 14, 2026
ggevay
left a comment
ggevay
left a comment
Contributor
There was a problem hiding this comment.
Hitting approve because we established at #37629 (comment) that the commit being reverted here caused a performance regression. (But I didn't check the details of the commit.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c590b0.
I tried to fix performance regression the change introduced in other benchmarks in #37627, but failed.
This feels safer. It's too bad we lose the ~2.5x improvement the PR had though.
Nightly perf. run shows us that we do lose some performance from reverting: https://buildkite.com/materialize/nightly/builds/17318