sql: accept WITH (WAIT ...) on ALTER CLUSTER unconditionally - #38104
Open
aljoscha wants to merge 1 commit into
Open
sql: accept WITH (WAIT ...) on ALTER CLUSTER unconditionally#38104aljoscha wants to merge 1 commit into
aljoscha wants to merge 1 commit into
Conversation
This was referenced Aug 7, 2026
aljoscha
force-pushed
the
aljoscha/cluster-legacy-04-zdt-flag
branch
from
August 7, 2026 08:00
b3e6c5d to
44e8e16
Compare
aljoscha
force-pushed
the
aljoscha/cluster-legacy-04-zdt-flag
branch
from
August 7, 2026 08:01
44e8e16 to
e06b9d6
Compare
aljoscha
marked this pull request as ready for review
August 7, 2026 08:14
aljoscha
force-pushed
the
aljoscha/cluster-legacy-04-zdt-flag
branch
from
August 7, 2026 08:28
e06b9d6 to
8f88cec
Compare
aljoscha
force-pushed
the
aljoscha/cluster-legacy-04-zdt-flag
branch
from
August 7, 2026 08:45
8f88cec to
f1f08b2
Compare
Graceful cluster reconfiguration has been behind the `enable_zero_downtime_cluster_reconfiguration` feature flag, default off, so the `WITH (WAIT ...)` surface was rejected at plan time unless a deployment turned it on. That is now the only thing standing between an operator and the synchronous cut-over, which is the escape hatch for a reshape when the cluster controller itself is the problem. A break-glass path behind a default-off flag is not a break-glass path. Remove the flag and the planner gate. The two rejections that share that code path stay: a `WAIT` without a replica-shape change, and a `WAIT` on an unmanaged cluster. Every test that used the surface enabled the flag itself, so those statements go. In a mixed-version run some phases execute against a released binary that still enforces the gate (platform-checks' graceful-reconfiguration check runs its first manipulate phase there), so `get_minimal_system_parameters` pins the flag on below v26.38 instead. The docs drop the private-preview badges: the surface is generally available once nothing gates it.
aljoscha
force-pushed
the
aljoscha/cluster-legacy-04-zdt-flag
branch
from
August 7, 2026 10:05
f1f08b2 to
c6c719e
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of the design stack. Stacked on #38103.
Why
Graceful cluster reconfiguration has lived behind
enable_zero_downtime_cluster_reconfiguration, default off, so the plannerrejected any
WITH (WAIT ...)clause unless a deployment turned the flag on.That flag is now the only thing standing between an operator and the synchronous
cut-over (#38103), which is the escape hatch for reshaping a cluster when the
cluster controller itself is the problem. On any deployment running the compiled
default there would be no way to reshape a cluster at all in that situation. A
break-glass path behind a default-off flag is not a break-glass path.
What lands
feature_flags!entry and therequire_feature_flagcall inplan_alter_cluster. Everything else about the flag is macro-derived, sothere is no second registry to update.
ALTER SYSTEM SET/RESETstatements go (testdrive, sqllogictest, pg-cdc,test/cluster/mzcompose.py, cloudtest, parallel-workload, and thegraceful-reconfiguration platform check).
get_minimal_system_parameterspins the flag on below v26.38 instead. This isload-bearing, not tidiness:
AlterClusterGracefulReconfigurationissuesWITH (WAIT UNTIL READY ...)in its first manipulate phase, which underUpgradeEntireMzruns against the last released binary, and that binary stillenforces the gate.
INTENTIONAL_LD_OVERRIDEStoKNOWN_STALE_LD_FLAGS. The flag is a real LDflag, so once the last release carrying it ages out the consistency check
would report it stale and fail. The flag should be archived in
LaunchDarkly, after which this entry can go too.
The two rejections that share the removed code path are untouched: a
WAITwithout a replica-shape change (
WAIT can only be used together with a SIZE, AVAILABILITY ZONES, or INTROSPECTION change) and aWAITon an unmanagedcluster (
ALTER... WITH not supported for unmanaged clusters). No test assertedthe gate's own error text, so nothing there changes.
enable_cluster_schedule_refreshis deliberately left alone at its currentdefault, even though it is the near-identical sibling gate a dozen lines below.
Reviewer attention, please
Two judgment calls worth a second opinion:
doc/user/content/sql/alter-cluster.mdareremoved. Nothing gates the surface after this, so describing it as private
preview is no longer accurate. If the preview status is a product decision
that has not been made yet, revert just that file and the rest still stands.
doc/user/content/releases/_index.mdis organizedby released version with release dates, and v26.38 has no section yet, so
there is nowhere to put one without inventing a date. Whoever writes the
v26.38 notes should announce that
WITH (WAIT ...)is generally available.