fix(query): Tab inserts a real tab character#267
Merged
Conversation
…still works - QueryTextArea now inserts "\t" on Tab in INSERT mode. - When the autocomplete dropdown is open, Tab accepts the suggestion instead. - Escape closes autocomplete when leaving INSERT mode. - Added unit and UI tests for Tab/autocomplete behavior.
Add focused UI coverage for replacing an active selection with Tab and for inserting Tab after autocomplete acceptance is rebound. Both tests intentionally fail against the current PR implementation so the behavior remains reproducible while the fix is developed. Constraint: This branch contains regression tests only and is based on PR 267 head Confidence: high Scope-risk: narrow Directive: Keep both tests when fixing the corresponding QueryTextArea behavior Tested: Both targeted tests fail for the expected production assertions; Ruff passes Not-tested: Production fix, because this commit intentionally adds failing regressions only Related: Maxteabag#267
Owner
|
Thanks for the PR! Could you merge test/pr-267-tab-regressions into this PR? It adds two failing regression tests for Tab selection replacement and custom autocomplete keybindings. |
Owner
|
If you have the capacity to adress the tests - it would be great. |
Contributor
Author
|
Done. Merged the test branch and fixed both regressions. All tests pass. |
pull Bot
pushed a commit
to Mu-L/sqlit
that referenced
this pull request
Jul 14, 2026
Autocomplete key bindings should keep working when users assign Tab to navigation or closing rather than acceptance. Dispatch the active binding once through Textual's guarded action system before falling back to literal tab insertion. Constraint: QueryTextArea intercepts Tab before normal key routing Rejected: Yield the event to bubbling | Textual handlers can process navigation twice Confidence: high Scope-risk: narrow Directive: Keep custom autocomplete bindings ahead of literal Tab insertion Tested: 15 focused tests; full suite 1716 passed and 646 skipped Not-tested: Three unrelated baseline failures reproduced on origin/main Related: Maxteabag#267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-07-07.at.15.32.31.mov