Fix Tab autocomplete action rebinding#270
Merged
Merged
Conversation
Autocomplete key bindings should keep working when users assign Tab to navigation or closing rather than acceptance. Dispatch the active binding once through Textual's guarded action system before falling back to literal tab insertion. Constraint: QueryTextArea intercepts Tab before normal key routing Rejected: Yield the event to bubbling | Textual handlers can process navigation twice Confidence: high Scope-risk: narrow Directive: Keep custom autocomplete bindings ahead of literal Tab insertion Tested: 15 focused tests; full suite 1716 passed and 646 skipped Not-tested: Three unrelated baseline failures reproduced on origin/main Related: #267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #267.