chore(deps): bump astro-eslint-parser 1.4.0 → 2.1.0 - #12093
Conversation
Merge Protections🟢 All 6 merge protections satisfied — ready to merge. Show 6 satisfied protections🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Pull request overview
Upgrades the astro-eslint-parser dev dependency to v2.1.0 and updates the ESLint flat config to account for the package becoming ESM-only with no default export, unblocking lint failures seen in the earlier Dependabot attempt.
Changes:
- Bump
astro-eslint-parserfrom^1.4.0to^2.1.0. - Update
eslint.config.jsto import the parser via a namespace import (import * as astroParser) so ESLint receives the expected parser object. - Refresh
pnpm-lock.yamlto reflect the new dependency graph (including the reduced transitive deps mentioned in the release notes).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
package.json |
Updates astro-eslint-parser version range to ^2.1.0. |
eslint.config.js |
Switches from default import to namespace import to match v2’s ESM named exports. |
pnpm-lock.yaml |
Lockfile update for astro-eslint-parser@2.1.0 and related transitive dependency changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@jd this pull request is now in conflict 😩 |
Major upgrade of the `astro-eslint-parser` dev dependency. Supersedes the failing Dependabot PR #12007, whose `lint` check was red because v2 is a breaking change. Breaking changes handled: - **v2 is now a pure named-export ESM module** — it no longer provides a `default` export. The old `import astroParser from 'astro-eslint-parser'` threw `SyntaxError: The requested module 'astro-eslint-parser' does not provide an export named 'default'` when ESLint loaded the flat config, which is exactly the failing `lint` check. Switched to a namespace import (`import * as astroParser`), which exposes `parseForESLint`/`meta` — the shape ESLint's flat-config `parser` expects. - **v2 drops old Node** (now requires `^22.22.3 || ^24.16.0 || >=26.3.0`). The repo's `.node-version` pins `24`, which CI resolves to the latest 24.x (well past 24.16), so no bump is needed. - v2.1.0 swaps fast-glob/is-glob for tinyglobby (transitive only); the lockfile shrinks accordingly, no source changes required. `pnpm check` (astro check + eslint + biome) passes clean locally. Supersedes #12007. Change-Id: Ieb581ee0f89a9f22c78f705ede03bfec1b479275
Revision history
|
343a847 to
f0d6fe6
Compare
Merge Queue Status
This pull request spent 2 minutes 51 seconds in the queue, including 2 minutes 17 seconds running CI. Required conditions to merge
|
Major upgrade of the
astro-eslint-parserdev dependency. Supersedes thefailing Dependabot PR #12007, whose
lintcheck was red because v2 is abreaking change.
Breaking changes handled:
defaultexport. The oldimport astroParser from 'astro-eslint-parser'threw
SyntaxError: The requested module 'astro-eslint-parser' does not provide an export named 'default'when ESLint loaded the flat config,which is exactly the failing
lintcheck. Switched to a namespace import(
import * as astroParser), which exposesparseForESLint/meta— theshape ESLint's flat-config
parserexpects.^22.22.3 || ^24.16.0 || >=26.3.0).The repo's
.node-versionpins24, which CI resolves to the latest24.x (well past 24.16), so no bump is needed.
lockfile shrinks accordingly, no source changes required.
pnpm check(astro check + eslint + biome) passes clean locally.Supersedes #12007.