Skip to content

chore(deps): bump astro-eslint-parser 1.4.0 → 2.1.0 - #12093

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/astro-eslint-parser-2/bump-astro-eslint-parser-1-4-0-2-1-0--eb581ee0
Jul 15, 2026
Merged

chore(deps): bump astro-eslint-parser 1.4.0 → 2.1.0#12093
mergify[bot] merged 1 commit into
mainfrom
devs/jd/jd/astro-eslint-parser-2/bump-astro-eslint-parser-1-4-0-2-1-0--eb581ee0

Conversation

@jd

@jd jd commented Jul 13, 2026

Copy link
Copy Markdown
Member

Major upgrade of the astro-eslint-parser dev dependency. Supersedes the
failing Dependabot PR #12007, whose lint check was red because v2 is a
breaking change.

Breaking changes handled:

  • v2 is now a pure named-export ESM module — it no longer provides a
    default export. The old import astroParser from 'astro-eslint-parser'
    threw SyntaxError: The requested module 'astro-eslint-parser' does not provide an export named 'default' when ESLint loaded the flat config,
    which is exactly the failing lint check. Switched to a namespace import
    (import * as astroParser), which exposes parseForESLint/meta — the
    shape ESLint's flat-config parser expects.
  • v2 drops old Node (now requires ^22.22.3 || ^24.16.0 || >=26.3.0).
    The repo's .node-version pins 24, which CI resolves to the latest
    24.x (well past 24.16), so no bump is needed.
  • v2.1.0 swaps fast-glob/is-glob for tinyglobby (transitive only); the
    lockfile shrinks accordingly, no source changes required.

pnpm check (astro check + eslint + biome) passes clean locally.

Supersedes #12007.

Copilot AI review requested due to automatic review settings July 13, 2026 10:09
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 13, 2026 10:09 Failure
@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 6 merge protections satisfied — ready to merge.

Show 6 satisfied protections

🟢 🤖 Continuous Integration

  • all of:
    • check-success = build
    • check-success = lint
    • check-success = test
    • any of:
      • check-success = test-broken-links
      • label = ignore-broken-links
    • any of:
      • check-success=Cloudflare Pages
      • -head-repo-full-name~=^Mergifyio/

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by >= 2
    • author = dependabot[bot]
    • author = mergify-ci-bot

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the astro-eslint-parser dev dependency to v2.1.0 and updates the ESLint flat config to account for the package becoming ESM-only with no default export, unblocking lint failures seen in the earlier Dependabot attempt.

Changes:

  • Bump astro-eslint-parser from ^1.4.0 to ^2.1.0.
  • Update eslint.config.js to import the parser via a namespace import (import * as astroParser) so ESLint receives the expected parser object.
  • Refresh pnpm-lock.yaml to reflect the new dependency graph (including the reduced transitive deps mentioned in the release notes).

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
package.json Updates astro-eslint-parser version range to ^2.1.0.
eslint.config.js Switches from default import to namespace import to match v2’s ESM named exports.
pnpm-lock.yaml Lockfile update for astro-eslint-parser@2.1.0 and related transitive dependency changes.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mergify
mergify Bot requested a review from a team July 13, 2026 10:11
@jd
jd marked this pull request as ready for review July 13, 2026 10:17
kozlek
kozlek previously approved these changes Jul 13, 2026
@mergify
mergify Bot requested a review from a team July 13, 2026 11:07
@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@jd this pull request is now in conflict 😩

@mergify mergify Bot added the conflict label Jul 14, 2026
Major upgrade of the `astro-eslint-parser` dev dependency. Supersedes the
failing Dependabot PR #12007, whose `lint` check was red because v2 is a
breaking change.

Breaking changes handled:

- **v2 is now a pure named-export ESM module** — it no longer provides a
  `default` export. The old `import astroParser from 'astro-eslint-parser'`
  threw `SyntaxError: The requested module 'astro-eslint-parser' does not
  provide an export named 'default'` when ESLint loaded the flat config,
  which is exactly the failing `lint` check. Switched to a namespace import
  (`import * as astroParser`), which exposes `parseForESLint`/`meta` — the
  shape ESLint's flat-config `parser` expects.
- **v2 drops old Node** (now requires `^22.22.3 || ^24.16.0 || >=26.3.0`).
  The repo's `.node-version` pins `24`, which CI resolves to the latest
  24.x (well past 24.16), so no bump is needed.
- v2.1.0 swaps fast-glob/is-glob for tinyglobby (transitive only); the
  lockfile shrinks accordingly, no source changes required.

`pnpm check` (astro check + eslint + biome) passes clean locally.

Supersedes #12007.

Change-Id: Ieb581ee0f89a9f22c78f705ede03bfec1b479275
@jd

jd commented Jul 15, 2026

Copy link
Copy Markdown
Member Author

Revision history

# Type Changes Reason Date
1 initial 343a847 2026-07-15 08:54 UTC
2 content 343a847 → f0d6fe6 rebase onto main; regenerate pnpm-lock.yaml to resolve lockfile conflict with concurrent dep bumps 2026-07-15 08:54 UTC

@jd
jd force-pushed the devs/jd/jd/astro-eslint-parser-2/bump-astro-eslint-parser-1-4-0-2-1-0--eb581ee0 branch from 343a847 to f0d6fe6 Compare July 15, 2026 08:54
@mergify
mergify Bot dismissed kozlek’s stale review July 15, 2026 08:54

Pull request has been modified.

@mergify
mergify Bot deployed to Mergify Merge Protections July 15, 2026 08:54 Active
@mergify mergify Bot removed the conflict label Jul 15, 2026
@mergify
mergify Bot requested a review from a team July 15, 2026 09:08
@mergify

mergify Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 51 seconds in the queue, including 2 minutes 17 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jul 15, 2026
@mergify
mergify Bot merged commit 8402709 into main Jul 15, 2026
8 of 13 checks passed
@mergify
mergify Bot deleted the devs/jd/jd/astro-eslint-parser-2/bump-astro-eslint-parser-1-4-0-2-1-0--eb581ee0 branch July 15, 2026 09:21
@mergify mergify Bot removed the queued label Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants