merge queue: checking main (5bfe300) and #12093 together - #12109
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (5bfe300) and #12093 together#12109mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
Major upgrade of the `astro-eslint-parser` dev dependency. Supersedes the failing Dependabot PR #12007, whose `lint` check was red because v2 is a breaking change. Breaking changes handled: - **v2 is now a pure named-export ESM module** — it no longer provides a `default` export. The old `import astroParser from 'astro-eslint-parser'` threw `SyntaxError: The requested module 'astro-eslint-parser' does not provide an export named 'default'` when ESLint loaded the flat config, which is exactly the failing `lint` check. Switched to a namespace import (`import * as astroParser`), which exposes `parseForESLint`/`meta` — the shape ESLint's flat-config `parser` expects. - **v2 drops old Node** (now requires `^22.22.3 || ^24.16.0 || >=26.3.0`). The repo's `.node-version` pins `24`, which CI resolves to the latest 24.x (well past 24.16), so no bump is needed. - v2.1.0 swaps fast-glob/is-glob for tinyglobby (transitive only); the lockfile shrinks accordingly, no source changes required. `pnpm check` (astro check + eslint + biome) passes clean locally. Supersedes #12007. Change-Id: Ieb581ee0f89a9f22c78f705ede03bfec1b479275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (5bfe300) and #12093 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #12093.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
author != dependabot[bot]author != mergify-ci-botgithub-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/