merge queue: checking main (b723ac5), #12204 and #12206 together#12222
Closed
mergify[bot] wants to merge 4 commits into
Closed
merge queue: checking main (b723ac5), #12204 and #12206 together#12222mergify[bot] wants to merge 4 commits into
mergify[bot] wants to merge 4 commits into
Conversation
First docs-health audit pass over the action reference pages. Accuracy fixes verified against the config JSON schema and the engine source: - queue: reference `auto_merge_conditions` instead of the deprecated `auto_merge` - comment: fix the copy-pasted rule name in the conflict example (was "comment when a pull request is merged" on a `conflict` condition) - delete_head_branch and rebase: convert dated deprecation notices to dateless markers per the repo rule (both dates had passed; the delete_head_branch date also disagreed with the engine's actual deadline, flagged separately in the audit report) - post_check: drop the unused Button import; name Merge Protections as the feature in prose Every documented option, default, and enum on all 21 action pages was cross-checked against the schema; the rest were accurate. Plus a conservative style pass per the proofread rubrics: banned words, promotional filler sentences, em dashes, and a dozen grammar fixes across 15 pages. Part of the first manual docs-health audit (MRGFY-8212). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Change-Id: I2b9d507db7a3e2ab566d70b0b15a28031f427962
… docs Docs are usually written *from* internal material: a support case, a private PR, an engine source file, a Linear ticket. That material travels with the draft, and nothing in the repo told an agent to leave it behind. A recent billing page was written from a support ticket whose context carried a helpdesk ticket ID, a thread ID, a customer org name, and a private shadow-office source path. None of that belongs on docs.mergify.com, and a leaked identifier cannot be unpublished. This follows the repo's existing agent-guidance structure rather than adding a parallel document: - **AGENTS.md** gains Critical Rule 8 plus a "Never Publish Internal Information" section listing concretely what must never ship (ticket and thread IDs, customer/org/account identifiers, private repo and source paths, internal trackers and admin URLs, credentials, internal framing), and how to fix a leak: state the behavior, drop the provenance. - **`proofread-leaks`** joins the proofread pipeline as a 5th subagent, written to match the existing proofread-* skills. It is the one proofreader that never skips: the pipeline's 10-line threshold and its "code blocks only" / "frontmatter only" exemptions are exactly where a one-line ticket ID hides, so those exemptions no longer apply to it. - **`pnpm check:internal-leaks`** (`scripts/check-internal-leaks.mjs`, plus a CI job) is the deterministic backstop, modelled on validate-config-examples: fixed patterns for ticket/thread IDs, private repo and source paths, and internal trackers and hostnames, with a per-line `internal-leaks: allow <rule>` escape hatch. - **docs-from-code**, **docs-gap-analysis**, and **document-a-feature** each gain a pointer, since those are the skills that pull internal material in. Every rule is narrow enough to leave today's docs clean (146 files scanned, 0 findings) and to ignore the placeholders the docs already use, so `ghp_*`, `<your-token>`, `Mergifyio/mergify`, and `app.datadoghq.com` do not fire. Credentials stay in the policy and in proofread-leaks' checklist, but the deterministic scan does not look for them: secret detection is not this script's job to reinvent. Judgment call worth a look: the ask was for instructions, and the CI scanner goes beyond that. I added it because the skill-level check only fires when an agent runs the pipeline, which leaves human edits and skipped passes uncovered, and because this is the one class of mistake that is unfixable after the fact. Happy to drop the script and keep the instructions if you would rather not carry the CI surface. The scanner cannot catch customer names, copied examples, or internal framing. That half stays with proofread-leaks, and the docs say so in both places so a green CI run is not mistaken for a clean bill of health. Change-Id: I56a581e7825816dbdc7e7f9be082f39d799cd72f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (b723ac5), #12204 and #12206 are queued together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #12206.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:depends-on = Mergifyio/docs#12205[⛓️ docs(configuration): fix reference accuracy and style drift #12205]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch] (documentation)schedule=Mon-Fri 09:00-17:30[Europe/Paris]Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/Required conditions to stay in the queue:
author != dependabot[bot]author != mergify-ci-botdepends-on = Mergifyio/docs#12205[⛓️ docs(configuration): fix reference accuracy and style drift #12205]github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch] (documentation)Enforce conventional commit]:title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:👀 Review Requirements]:#approved-reviews-by >= 2author = dependabot[bot]author = mergify-ci-bot📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0🤖 Continuous Integration]:check-success = buildcheck-success = lintcheck-success = testcheck-success = test-broken-linkslabel = ignore-broken-linkscheck-success=Cloudflare Pages-head-repo-full-name~=^Mergifyio/