Skip to content

merge queue: checking #12689 on main (7d475b8) - #12699

Draft
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/d415365435
Draft

merge queue: checking #12689 on main (7d475b8)#12699
mergify[bot] wants to merge 2 commits into
mainfrom
mergify/merge-queue/d415365435

Conversation

@mergify

@mergify mergify Bot commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🎉 This pull request has been checked successfully and will be merged when the schedule will match. 🎉

#12689 is queued for merge on branch main (7d475b8).

This pull request has been created by Mergify to check the mergeability of #12689.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: 7d475b8357a55d29537fd747c1a5ac7aa2ecfb38
previous_check_retries: []
previous_failed_batches: []
pull_requests:
  - number: 12689
    scopes: []
scopes: []
...

flagendijk89 and others added 2 commits September 4, 2026 21:10
@flagendijk89 @claude
fix(search): return the page a query names, not a heading inside it
0af96db 
Searching a build tool never returned that tool's page. "bazel" answered
with "Detecting Scopes with bazel-diff", landing the reader past the
"Configuring Manual Scopes" step every one of those pages opens with;
"pants" returned two results and neither was the Pants page.

Two causes, one on each side of the index.

The page-level record held only the intro paragraph and the meta
description, so it was always the thinnest record for its own page and
lost to every heading on it. It now holds the whole page, which lets
relevance decide instead of record size: a page-wide query matches it
across its whole length and wins, while a section-specific query
("barrier files") still goes to the heading, because a short record
dense in those terms outscores a long one where they are diluted. The
`if (introBody)` guard is gone too — a page with no intro was missing
from the index entirely rather than merely ranking low.

The client then kept one result per URL, first wins, so the winning
heading silently evicted the page record. It now groups a page's records
and lets the page answer when the query names the page.

Also here, all visible in the results list:

- Whole-word title matches sort above incidental ones. "direct merge"
  ranked "Using TestNG Directly" first, matching "Direct" inside
  "Directly" — a match nobody typing those two words meant.
- Rows whose title did not match now carry Pagefind's excerpt. Half a
  result list could otherwise show no highlight and no snippet, with
  nothing on screen explaining why those rows were there.
- Heading permalinks are stripped before indexing. `CliCommand.astro`
  and `Endpoint.astro` put a literal "#" inside the `<h2>`, which is how
  "List a test's executions #" reached the results.
- Changelog titles are demoted alongside their bodies. Demoting only the
  body left every entry's headline at full title weight, so a changelog
  post outranked the page it was announcing.
- Properties sit after the body in each record, so a bare list of config
  keywords stops winning the excerpt over prose.

The full-text page records grow the index 8.7M to 9.0M (+3.4%);
fragments load lazily, so per-search transfer is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Change-Id: I91bd9f09d1025d6ea0dc66eec979fc782731aeb6
Claude-Session-Id: 18413631-aa75-4182-9e79-4c1ce31bb683
@mergify
Merge of #12689
5e4a665
@mergify
mergify Bot deployed to Mergify Merge Protections September 5, 2026 19:26 Active
@mergify mergify Bot mentioned this pull request Sep 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@flagendijk89