-
Notifications
You must be signed in to change notification settings - Fork 10
chore(scopes): split cli.py #801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(scopes): split cli.py #801
Conversation
Change-Id: Ie5407966b13820fa4982004e2ecc983c0e5f5a83
|
This pull request is part of a stack:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the cli.py module by splitting it into separate modules for better code organization. The main functionality is extracted from cli.py into dedicated modules for base detection and changed files handling.
- Split base detection logic into a separate
base_detector.pymodule - Extract git changed files functionality to
changed_files.pymodule - Update import statements and function calls to use the new modular structure
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mergify_cli/ci/scopes/cli.py | Updated imports and function calls to use new modules |
| mergify_cli/ci/scopes/base_detector.py | New module containing base detection logic extracted from cli.py |
| mergify_cli/ci/scopes/changed_files.py | New module containing git changed files functionality |
| mergify_cli/tests/ci/scopes/test_cli.py | Updated test imports and removed tests that moved to other modules |
| mergify_cli/tests/ci/scopes/test_base_detector.py | New test file for base detector module |
| mergify_cli/tests/ci/scopes/test_changed_files.py | New test file for changed files module |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 040a81b. 🟢 All jobs passed!But CI Insights is watching 👀 |
No description provided.