Skip to content

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 8, 2025

No description provided.

Change-Id: Ie5407966b13820fa4982004e2ecc983c0e5f5a83
Copilot AI review requested due to automatic review settings October 8, 2025 09:35
@sileht
Copy link
Member Author

sileht commented Oct 8, 2025

This pull request is part of a stack:

  1. chore(scopes): split cli.py (#801) 👈
  2. feat(scopes): fetch commits until we found the base sha (#804)
  3. feat(scopes): automatically add a merge-queue scopes (#805)
  4. feat(scopes): upload scopes to Mergify API (#806)
  5. chore: remove click.Exception from modules (#807)
  6. fix: better handling of GitHub events (#808)

@mergify mergify bot deployed to Mergify Merge Protections October 8, 2025 09:35 Active
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the cli.py module by splitting it into separate modules for better code organization. The main functionality is extracted from cli.py into dedicated modules for base detection and changed files handling.

  • Split base detection logic into a separate base_detector.py module
  • Extract git changed files functionality to changed_files.py module
  • Update import statements and function calls to use the new modular structure

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
mergify_cli/ci/scopes/cli.py Updated imports and function calls to use new modules
mergify_cli/ci/scopes/base_detector.py New module containing base detection logic extracted from cli.py
mergify_cli/ci/scopes/changed_files.py New module containing git changed files functionality
mergify_cli/tests/ci/scopes/test_cli.py Updated test imports and removed tests that moved to other modules
mergify_cli/tests/ci/scopes/test_base_detector.py New test file for base detector module
mergify_cli/tests/ci/scopes/test_changed_files.py New test file for changed files module

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=test (macos-15)
    • check-success=test (ubuntu-24.04)
    • check-success=test (windows-2025)

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025

🧪 CI Insights

Here's what we observed from your CI run for 040a81b.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team October 8, 2025 09:38
@mergify mergify bot merged commit da2248b into main Oct 9, 2025
8 checks passed
@mergify mergify bot added the queued label Oct 9, 2025
@mergify mergify bot deleted the devs/sileht/fetch-for-diff/Ie5407966b13820fa4982004e2ecc983c0e5f5a83 branch October 9, 2025 09:00
@mergify mergify bot removed the queued label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants