Skip to content

chore: remove click.Exception from modules #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 1 commit into from
Oct 10, 2025
Merged

chore: remove click.Exception from modules #807

mergify merged 1 commit into from
Oct 10, 2025

Conversation

@sileht
Copy link
Member

@sileht sileht commented Oct 9, 2025 •
edited
Loading

For separation of concern only the root module should use it.

@mergify mergify bot had a problem deploying to Mergify Merge Protections October 9, 2025 07:55 Failure
This was referenced Oct 9, 2025
Merged
Merged
Merged
Merged
@sileht
Copy link
Member Author

sileht commented Oct 9, 2025 •
edited
Loading

This pull request is part of a stack:

  1. chore: remove click.Exception from modules (#807) 👈
  2. fix: better handling of GitHub events (#808)
  3. feat: change configuration file format (#811)

@sileht sileht mentioned this pull request Oct 9, 2025
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025 •
edited
Loading

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 🤖 Continuous Integration

Wonderful, this rule succeeded.
  • all of:
    • check-success=test (macos-15)
    • check-success=test (ubuntu-24.04)
    • check-success=test (windows-2025)

🟢 👀 Review Requirements

Wonderful, this rule succeeded.
  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]
    • author = renovate[bot]

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?:

🟢 🔎 Reviews

Wonderful, this rule succeeded.
  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 2128c9e.

🟢 All jobs passed!

But CI Insights is watching 👀

@mergify mergify bot requested a review from a team October 9, 2025 07:57
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from 6efa181 to d07334f Compare October 9, 2025 11:53
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from b340745 to 3696086 Compare October 9, 2025 11:53
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 9, 2025 11:53 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from d07334f to dc1b465 Compare October 9, 2025 14:31
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from 3696086 to 28ae4bc Compare October 9, 2025 14:31
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 9, 2025 14:32 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from dc1b465 to e93bf88 Compare October 10, 2025 07:09
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from 28ae4bc to f2a483b Compare October 10, 2025 07:10
@sileht sileht mentioned this pull request Oct 10, 2025
Closed
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 07:10 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from e93bf88 to cd003f0 Compare October 10, 2025 07:27
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from f2a483b to 20ade2f Compare October 10, 2025 07:27
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 07:28 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from cd003f0 to 07809cd Compare October 10, 2025 08:35
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from 20ade2f to ad8be03 Compare October 10, 2025 08:35
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 08:36 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from 07809cd to cd6d784 Compare October 10, 2025 08:48
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 10, 2025
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from cd6d784 to 1155b69 Compare October 10, 2025 08:51
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from ad8be03 to 179ce85 Compare October 10, 2025 09:33
@mergify mergify bot removed the conflict label Oct 10, 2025
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 09:34 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from 1155b69 to b2e712e Compare October 10, 2025 11:55
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from 179ce85 to d279991 Compare October 10, 2025 11:55
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 11:56 Failure
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 branch from b2e712e to 716c97a Compare October 10, 2025 13:02
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from d279991 to 94f627b Compare October 10, 2025 13:02
@mergify mergify bot had a problem deploying to Mergify Merge Protections October 10, 2025 13:03 Failure
Base automatically changed from devs/sileht/fetch-for-diff/I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2 to main October 10, 2025 13:40
@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2025

@sileht this pull request is now in conflict 😩

@mergify mergify bot added the conflict label Oct 10, 2025
JulianMaurin
JulianMaurin previously approved these changes Oct 10, 2025
View reviewed changes
@sileht
chore: remove click.Exception from modules
2128c9e 
For separation of concern only the root module should use it.

Change-Id: I7a52b1d654501d31f17fb69d28e946d4536cc3c9
@sileht sileht force-pushed the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch from 94f627b to 2128c9e Compare October 10, 2025 14:07
@mergify mergify bot removed the conflict label Oct 10, 2025
@mergify mergify bot dismissed JulianMaurin’s stale review October 10, 2025 14:07

Pull request has been modified.

@mergify mergify bot deployed to Mergify Merge Protections October 10, 2025 14:07 Active
@mergify mergify bot requested a review from a team October 10, 2025 14:08
remyduthu
remyduthu approved these changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@remyduthu remyduthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean 🧽

@mergify mergify bot merged commit 9216510 into main Oct 10, 2025
8 checks passed
@mergify mergify bot deleted the devs/sileht/fetch-for-diff/I7a52b1d654501d31f17fb69d28e946d4536cc3c9 branch October 10, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyduthu remyduthu remyduthu approved these changes

@JulianMaurin JulianMaurin JulianMaurin approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sileht @remyduthu @JulianMaurin