-
Notifications
You must be signed in to change notification settings - Fork 10
feat(scopes): upload scopes to Mergify API #806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scopes): upload scopes to Mergify API #806
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 👀 Review RequirementsWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 ReviewsWonderful, this rule succeeded.
|
🧪 CI InsightsHere's what we observed from your CI run for 716c97a. 🟢 All jobs passed!But CI Insights is watching 👀 |
7bb0004 to
59313f1
Compare
59313f1 to
5e1af89
Compare
5e1af89 to
90b0ec1
Compare
90b0ec1 to
6d24897
Compare
6d24897 to
6efa181
Compare
b0b6f99 to
49af629
Compare
6efa181 to
d07334f
Compare
49af629 to
fe2a38d
Compare
d07334f to
dc1b465
Compare
|
@sileht this pull request is now in conflict 😩 |
dc1b465 to
e93bf88
Compare
e93bf88 to
cd003f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds functionality to upload scope detection results to the Mergify API. The scopes command now not only detects which scopes are impacted by changed files but also uploads this information to Mergify when running in CI environments.
Key changes:
- Enhanced scopes CLI command to upload detected scopes to Mergify API
- Added utility functions for GitHub event handling and boolean environment variable parsing
- Implemented HTTP client for Mergify API communication
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| mergify_cli/utils.py | Added Mergify HTTP client, GitHub event parsing, and boolean environment utilities |
| mergify_cli/ci/scopes/cli.py | Modified detect function to return DetectedScope dataclass and added upload_scopes function |
| mergify_cli/ci/scopes/base_detector.py | Refactored GitHub event handling to use centralized utility function |
| mergify_cli/ci/detector.py | Added GitHub PR number detection and refactored boolean parsing to use utility |
| mergify_cli/ci/cli.py | Enhanced scopes command with API upload functionality and parameter validation |
| mergify_cli/tests/* | Comprehensive test coverage for new functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cd003f0 to
07809cd
Compare
07809cd to
cd6d784
Compare
cd6d784 to
1155b69
Compare
1155b69 to
b2e712e
Compare
This will be used like this: ``` mergify ci scopes --write $RUNNER_TEMP/mergify-scopes.json mergify ci scopes-send --file $RUNNER_TEMP/mergify-scopes.json ``` Change-Id: I913ec1dfc5a9b9fd50253e67f453e8c3328eb2e2
b2e712e to
716c97a
Compare
This will be used like this: