BREAKING: Allow RateLimitController to define a rate-limit per method#1355
Merged
GuillaumeRx merged 5 commits intomainfrom May 23, 2023
Merged
BREAKING: Allow RateLimitController to define a rate-limit per method#1355GuillaumeRx merged 5 commits intomainfrom
RateLimitController to define a rate-limit per method#1355GuillaumeRx merged 5 commits intomainfrom
Conversation
GuillaumeRx
force-pushed
the
gr/rate-limit-controller-method-config
branch
from
a7b08ca to
24ee3f0
Compare
legobeat
reviewed
May 10, 2023
legobeat
reviewed
May 10, 2023
GuillaumeRx
force-pushed
the
gr/rate-limit-controller-method-config
branch
from
c1b90d5 to
3101525
Compare
FrederikBolding
changed the title
RateLimitController to define a rate-limit per methodRateLimitController to define a rate-limit per method
GuillaumeRx
force-pushed
the
gr/rate-limit-controller-method-config
branch
from
0688880 to
824d6e2
Compare
FrederikBolding
approved these changes
May 23, 2023
brad-decker
pushed a commit
to dragana8/core
that referenced
this pull request
Jun 1, 2023
…od (MetaMask#1355) * allow `RateLimitController` to define a rate-limit per method * add JSDoc to `RateLimitedApi` * use nullish coalescing operator * update test * use `.toString()` instead of casting
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…od (#1355) * allow `RateLimitController` to define a rate-limit per method * add JSDoc to `RateLimitedApi` * use nullish coalescing operator * update test * use `.toString()` instead of casting
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…od (#1355) * allow `RateLimitController` to define a rate-limit per method * add JSDoc to `RateLimitedApi` * use nullish coalescing operator * update test * use `.toString()` instead of casting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the
RateLimitControllerso defining a rate limit for a specific method is possible.This changes the structure of the passed API config object.
Changes
References
RateLimitControllerto have a per method rate limit #1314Checklist