Skip to content

chore!: Update CurrencyRateController to expose all methods through messenger#8561

Merged
GuillaumeRx merged 9 commits intomainfrom
gr/export-methods-messenger-currency-rate
Apr 23, 2026
Merged

chore!: Update CurrencyRateController to expose all methods through messenger#8561
GuillaumeRx merged 9 commits intomainfrom
gr/export-methods-messenger-currency-rate

Conversation

@GuillaumeRx
Copy link
Copy Markdown
Contributor

@GuillaumeRx GuillaumeRx commented Apr 23, 2026

Explanation

This updates the CurrencyRateController to expose all methods through the messenger in a standardized way.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Medium risk because it introduces a breaking rename of the CurrencyRateController get-state action type and changes the controller’s messenger surface area, requiring downstream type/import updates.

Overview
CurrencyRateController now exposes setCurrentCurrency and updateExchangeRate via the messenger by registering method action handlers, and adds generated method action type definitions for these calls.

This standardizes/renames the get-state messenger action type from GetCurrencyRateState to CurrencyRateControllerGetStateAction (type-only breaking change) and updates internal consumers (MultichainAssetsRatesController, TokenSearchDiscoveryDataController, and bridge-controller) plus exports the new action types from assets-controllers.

Reviewed by Cursor Bugbot for commit ee67d75. Bugbot is set up for automated code reviews on this repo. Configure here.

@GuillaumeRx GuillaumeRx force-pushed the gr/export-methods-messenger-currency-rate branch from b2d72c0 to f75d458 Compare April 23, 2026 09:59
@GuillaumeRx GuillaumeRx marked this pull request as ready for review April 23, 2026 10:02
@GuillaumeRx GuillaumeRx requested review from a team as code owners April 23, 2026 10:02
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0fd82e9. Configure here.

Comment thread packages/assets-controllers/src/CurrencyRateController.ts
GeorgeGkas
GeorgeGkas previously approved these changes Apr 23, 2026
Comment thread packages/assets-controllers/src/CurrencyRateController.ts
Comment thread packages/assets-controllers/CHANGELOG.md
@GuillaumeRx GuillaumeRx changed the title chore: Update CurrencyRateController to expose all methods through messenger chore!: Update CurrencyRateController to expose all methods through messenger Apr 23, 2026
sahar-fehri
sahar-fehri previously approved these changes Apr 23, 2026
@GuillaumeRx GuillaumeRx force-pushed the gr/export-methods-messenger-currency-rate branch from dafb173 to b629b48 Compare April 23, 2026 13:22
@GuillaumeRx GuillaumeRx force-pushed the gr/export-methods-messenger-currency-rate branch from b629b48 to 83c9675 Compare April 23, 2026 13:22
@GuillaumeRx GuillaumeRx enabled auto-merge April 23, 2026 14:38
@GuillaumeRx GuillaumeRx added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit c477081 Apr 23, 2026
358 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/export-methods-messenger-currency-rate branch April 23, 2026 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants