-
-
Notifications
You must be signed in to change notification settings - Fork 278
chore!: Update CurrencyRateController to expose all methods through messenger
#8561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1f39b31
register `CurrencyRateController` public methods to messenger
GuillaumeRx 283824a
update suppressions
GuillaumeRx f63fce8
update CHANGELOG
GuillaumeRx 77d4482
fix `eslint-suppressions.json` formatting
GuillaumeRx 6cf26c1
fix formatting
GuillaumeRx 9e1cce9
do not export `MESSENGER_EXPOSED_METHODS`
GuillaumeRx ccc55d2
update CHANGELOG
GuillaumeRx 83c9675
fix CHANGELOG after rebase
GuillaumeRx ee67d75
fix CHANGELOG formatting
GuillaumeRx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 33 additions & 0 deletions
33
packages/assets-controllers/src/CurrencyRateController-method-action-types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * This file is auto generated. | ||
| * Do not edit manually. | ||
| */ | ||
|
|
||
| import type { CurrencyRateController } from './CurrencyRateController'; | ||
|
|
||
| /** | ||
| * Sets a currency to track. | ||
| * | ||
| * @param currentCurrency - ISO 4217 currency code. | ||
| */ | ||
| export type CurrencyRateControllerSetCurrentCurrencyAction = { | ||
| type: `CurrencyRateController:setCurrentCurrency`; | ||
| handler: CurrencyRateController['setCurrentCurrency']; | ||
| }; | ||
|
|
||
| /** | ||
| * Updates the exchange rate for the current currency and native currency pairs. | ||
| * | ||
| * @param nativeCurrencies - The native currency symbols to fetch exchange rates for. | ||
| */ | ||
| export type CurrencyRateControllerUpdateExchangeRateAction = { | ||
| type: `CurrencyRateController:updateExchangeRate`; | ||
| handler: CurrencyRateController['updateExchangeRate']; | ||
| }; | ||
|
|
||
| /** | ||
| * Union of all CurrencyRateController action types. | ||
| */ | ||
| export type CurrencyRateControllerMethodActions = | ||
| | CurrencyRateControllerSetCurrentCurrencyAction | ||
| | CurrencyRateControllerUpdateExchangeRateAction; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.