feat: add tracing to multi srp features #31354

montelaidev · 2025-03-27T13:57:45Z

Description

This PR adds performances tracing to adding eth accounts to multiple srps, importing srp, and revealing srps.

Related issues

Fixes:

Manual testing steps

Open sentry and go to the traces in the dev environment.
Import a new srp and see that a new trace has been added.
Create a new account and see that a new trace has been added.
Reveal a srp and see that a new trace has been added.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-03-27T13:57:59Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2025-03-27T14:36:17Z

Builds ready [eb7422f]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (MMI): chrome
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Bundle Size Stats
mv2: E2e Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

Page Load Metrics (3632 ± 1200 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1781	13525	3227	2414	1159
		domContentLoaded	1636	12799	2860	2317	1113
		load	1895	14041	3632	2500	1200
		domInteractive	27	1000	94	209	100
		backgroundConnect	129	1959	774	473	227
		firstReactRender	38	287	148	62	30
		getState	42	847	333	210	101
		initialActions	0	1	0	0	0
		loadScripts	1154	11198	2040	2114	1015
		setupStore	19	589	203	138	66
		uiStartup	3435	18741	7928	4229	2031

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 396 Bytes (0.00%)
common: 79 Bytes (0.00%)

metamaskbot · 2025-04-02T13:54:42Z

✨ Files requiring CODEOWNER review ✨

🖥️ @MetaMask/wallet-ux (1 files, +10 -4)

📁 ui/
- 📁 components/
  - 📁 multichain/
    - 📁 create-eth-account/
      - 📄 create-eth-account.js +10 -4

metamaskbot · 2025-04-02T14:29:23Z

Builds ready [d5ad618]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 58 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1073	1326	58	1231	1303
			load	1036	929	1174	53	958	993
			domContentLoaded	1031	926	1165	53	955	989
			domInteractive	16	13	39	4	16	27
			firstPaint	738	131	1174	398	259	985
			backgroundConnect	9	6	42	4	9	10
			firstReactRender	19	15	68	6	20	31
			getState	12	4	34	8	6	8
			initialActions	0	0	1	0	0	1
			loadScripts	816	716	952	51	852	913
			setupStore	8	5	25	3	7	8
	Webpack	Home	uiStartup	2121	1686	2629	218	2257	2472
			load	1641	1310	2070	173	1744	1982
			domContentLoaded	1632	1307	2005	166	1741	1972
			domInteractive	17	12	67	12	14	53
			firstPaint	183	66	341	60	233	71
			backgroundConnect	31	15	281	29	30	65
			firstReactRender	213	61	353	118	83	97
			getState	9	4	19	3	8	9
			initialActions	3	1	4	1	3	4
			loadScripts	1623	1304	1979	162	1730	1944
			setupStore	27	7	265	53	20	8
Firefox	Browserify	Home	uiStartup	1381	1187	1829	151	1433	1779
			load	1243	1057	1675	142	1294	1627
			domContentLoaded	1243	1057	1675	142	1293	1627
			domInteractive	102	37	167	24	88	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	22	16	44	5	23	31
			firstReactRender	22	19	35	3	24	26
			getState	6	3	13	2	7	9
			initialActions	0	0	2	0	0	1
			loadScripts	1222	1040	1653	141	1277	1601
			setupStore	6	4	34	4	6	7
	Webpack	Home	uiStartup	1521	1338	2001	157	1570	1920
			load	1312	1145	1779	146	1347	1666
			domContentLoaded	1312	1145	1778	146	1347	1665
			domInteractive	91	38	178	25	88	96
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	48	5	26	35
			firstReactRender	35	28	47	5	37	44
			getState	9	4	56	7	8	9
			initialActions	0	0	2	1	1	1
			loadScripts	1289	1122	1755	145	1324	1640
			setupStore	7	5	29	3	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 316 Bytes (0%)
common: 79 Bytes (0%)

metamaskbot · 2025-04-03T02:02:40Z

Builds ready [85092a8]

builds: chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
- content-script: 0
- offscreen: 0

UI Startup Metrics (1189 ± 69 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1189	1070	1396	69	1243	1298
			load	1033	905	1164	64	929	990
			domContentLoaded	1028	894	1160	64	927	990
			domInteractive	15	13	30	4	15	26
			firstPaint	802	133	1164	377	256	992
			backgroundConnect	10	6	132	13	9	10
			firstReactRender	18	13	35	3	18	25
			getState	10	4	33	6	6	7
			initialActions	0	0	1	0	0	1
			loadScripts	815	683	949	65	859	925
			setupStore	7	5	19	2	7	8
	Webpack	Home	uiStartup	2074	1675	2587	217	2190	2510
			load	1611	1301	2001	166	1720	1934
			domContentLoaded	1604	1297	1972	163	1714	1911
			domInteractive	17	12	59	11	14	51
			firstPaint	187	80	330	53	231	80
			backgroundConnect	27	14	82	15	29	70
			firstReactRender	180	53	362	114	85	94
			getState	9	4	27	4	8	9
			initialActions	3	1	4	1	3	4
			loadScripts	1596	1294	1946	160	1702	1885
			setupStore	31	7	300	65	21	9
Firefox	Browserify	Home	uiStartup	1372	1182	2009	169	1398	1816
			load	1232	1043	1865	163	1263	1666
			domContentLoaded	1232	1042	1865	163	1263	1666
			domInteractive	97	35	187	27	90	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	17	145	14	26	39
			firstReactRender	23	19	49	4	23	30
			getState	7	4	38	4	7	8
			initialActions	0	0	1	0	0	1
			loadScripts	1209	1026	1831	157	1240	1623
			setupStore	6	4	18	2	6	8
	Webpack	Home	uiStartup	1554	1382	2076	150	1607	1964
			load	1339	1179	1841	141	1371	1710
			domContentLoaded	1338	1179	1841	141	1371	1710
			domInteractive	102	47	176	22	93	98
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	25	18	50	6	27	43
			firstReactRender	35	28	59	6	38	47
			getState	9	4	32	7	8	9
			initialActions	1	0	2	1	1	1
			loadScripts	1316	1158	1816	140	1349	1683
			setupStore	8	5	30	5	8	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 316 Bytes (0%)
common: 79 Bytes (0%)

…mance-tracing

metamaskbot · 2025-04-28T09:29:14Z

Builds ready [c6c0224]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all CircleCI artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1192 ± 61 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1192	1063	1351	61	1236	1303
			load	1035	925	1206	60	1075	1133
			domContentLoaded	1029	920	1192	60	1068	1129
			domInteractive	17	14	57	5	16	27
			firstPaint	697	142	1204	414	1052	1132
			backgroundConnect	7	4	19	2	7	10
			firstReactRender	22	15	51	7	21	38
			getState	13	5	30	7	19	27
			initialActions	0	0	1	0	0	1
			loadScripts	795	698	948	58	839	899
			setupStore	8	5	18	3	8	16
	Webpack	Home	uiStartup	2217	1830	2686	190	2362	2516
			load	1722	1411	2125	155	1839	1988
			domContentLoaded	1715	1407	2115	153	1830	1982
			domInteractive	17	12	71	11	14	49
			firstPaint	184	65	535	71	226	324
			backgroundConnect	30	9	333	35	29	76
			firstReactRender	205	57	381	125	343	367
			getState	20	3	304	43	15	41
			initialActions	3	1	8	1	4	6
			loadScripts	1710	1406	2091	151	1827	1981
			setupStore	22	7	233	29	23	39
Firefox	Browserify	Home	uiStartup	1390	1219	1672	101	1451	1625
			load	1237	1056	1515	105	1311	1463
			domContentLoaded	1236	1056	1515	105	1310	1462
			domInteractive	113	37	350	44	123	176
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	108	11	20	35
			firstReactRender	24	20	54	6	24	34
			getState	7	4	23	2	8	10
			initialActions	0	0	1	0	0	1
			loadScripts	1218	1042	1498	106	1293	1443
			setupStore	8	4	209	20	6	8
	Webpack	Home	uiStartup	1480	1279	1898	114	1571	1679
			load	1272	1114	1580	100	1354	1448
			domContentLoaded	1272	1114	1580	100	1353	1448
			domInteractive	83	51	152	21	91	135
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	14	96	11	23	42
			firstReactRender	35	28	74	6	37	44
			getState	9	4	47	7	9	29
			initialActions	1	0	2	1	1	1
			loadScripts	1251	1099	1564	98	1338	1426
			setupStore	8	5	32	5	8	27

Benchmark value 2218 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1722 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1716 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 1711 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2517 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1981 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 113 exceeds gate value 110 for firefox browserify home mean domInteractive
Sum of mean exceeds: 64ms | Sum of p95 exceeds: 74ms
Sum of all benchmark exceeds: 138ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 489 Bytes (0.01%)
common: 79 Bytes (0%)

ui/pages/keychains/reveal-seed.js

ui/components/multichain/create-eth-account/create-eth-account.js

…mance-tracing

metamaskbot · 2025-05-30T10:10:34Z

Builds ready [d30c7f8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1206 ± 70 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1206	1082	1489	70	1245	1325
			load	1041	934	1306	62	1083	1129
			domContentLoaded	1033	920	1300	62	1073	1118
			domInteractive	16	13	45	5	16	28
			firstPaint	780	85	1308	400	1060	1121
			backgroundConnect	8	4	30	5	8	23
			firstReactRender	21	15	52	7	22	36
			getState	15	6	40	8	19	31
			initialActions	0	0	1	0	0	0
			loadScripts	794	684	1028	60	835	889
			setupStore	8	5	22	3	9	13
	Webpack	Home	uiStartup	2141	1750	2705	234	2318	2519
			load	1662	1358	2043	180	1790	1989
			domContentLoaded	1655	1354	2029	179	1784	1984
			domInteractive	16	12	62	11	13	53
			firstPaint	172	66	1601	153	192	272
			backgroundConnect	23	11	68	8	27	39
			firstReactRender	150	44	363	108	279	331
			getState	16	4	342	34	13	30
			initialActions	3	1	7	1	3	4
			loadScripts	1652	1352	2018	177	1781	1980
			setupStore	38	6	312	76	20	300
Firefox	Browserify	Home	uiStartup	1382	1189	1845	126	1435	1716
			load	1214	1060	1499	98	1288	1395
			domContentLoaded	1214	1060	1499	98	1288	1395
			domInteractive	94	37	167	25	106	141
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	21	13	97	11	22	39
			firstReactRender	25	20	60	6	24	33
			getState	13	5	224	31	9	28
			initialActions	0	0	1	0	0	1
			loadScripts	1195	1047	1483	97	1270	1370
			setupStore	12	4	281	33	7	36
	Webpack	Home	uiStartup	1683	1446	2321	187	1776	2083
			load	1455	1233	2030	174	1560	1857
			domContentLoaded	1455	1233	2030	174	1560	1857
			domInteractive	83	42	162	21	88	131
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	26	16	96	13	25	58
			firstReactRender	45	30	56	4	47	50
			getState	13	5	205	22	10	29
			initialActions	1	0	3	1	1	1
			loadScripts	1433	1216	1991	172	1539	1830
			setupStore	9	6	30	4	9	14

cc: @HowardBraham
Benchmark value 23 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 38 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2519 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 1980 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 300 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 14 exceeds gate value 11 for firefox browserify home mean getState
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1716 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 28 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1683 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1456 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1455 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 45 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1433 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 2083 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1857 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1857 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 58 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 1830 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 311ms | Sum of p95 exceeds: 1135ms
Sum of all benchmark exceeds: 1446ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 505 Bytes (0.01%)
common: 79 Bytes (0%)

metamaskbot · 2025-05-30T15:34:54Z

Builds ready [d8405c8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
bundle size: Bundle Size Stats
user-actions-benchmark: User Actions Stats
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7, 8
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
- content-script: 0
- offscreen: 0

UI Startup Metrics (1229 ± 75 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Home	uiStartup	1229	1073	1508	75	1276	1374
			load	1060	946	1259	64	1095	1174
			domContentLoaded	1052	937	1254	66	1085	1168
			domInteractive	16	13	33	4	17	28
			firstPaint	693	80	1257	425	1073	1156
			backgroundConnect	9	4	49	7	9	27
			firstReactRender	21	16	46	5	21	30
			getState	15	6	47	9	21	31
			initialActions	0	0	1	0	0	1
			loadScripts	808	689	997	65	841	928
			setupStore	8	5	18	2	8	11
	Webpack	Home	uiStartup	2125	1718	2565	214	2276	2501
			load	1646	1333	1940	151	1749	1893
			domContentLoaded	1640	1329	1930	150	1745	1882
			domInteractive	15	12	59	9	13	43
			firstPaint	154	68	313	51	175	251
			backgroundConnect	24	10	61	10	27	49
			firstReactRender	139	43	413	103	178	333
			getState	20	4	330	53	14	38
			initialActions	5	1	268	26	3	5
			loadScripts	1636	1323	1919	149	1744	1871
			setupStore	35	6	311	70	20	296
Firefox	Browserify	Home	uiStartup	1353	1176	1842	131	1417	1605
			load	1195	1032	1538	113	1267	1433
			domContentLoaded	1195	1032	1538	113	1267	1432
			domInteractive	99	35	222	30	105	172
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	23	13	242	25	21	46
			firstReactRender	23	20	59	5	23	29
			getState	10	4	162	18	8	14
			initialActions	0	0	1	0	0	1
			loadScripts	1176	1021	1507	111	1248	1408
			setupStore	8	4	132	14	6	12
	Webpack	Home	uiStartup	1562	1354	2086	170	1643	1975
			load	1348	1162	1765	143	1429	1667
			domContentLoaded	1348	1162	1764	143	1429	1666
			domInteractive	77	60	218	21	83	109
			firstPaint	NaN	NaN	NaN	NaN	NaN	NaN
			backgroundConnect	24	15	228	22	23	36
			firstReactRender	41	29	64	5	43	49
			getState	11	4	243	24	9	29
			initialActions	0	0	2	1	1	1
			loadScripts	1327	1145	1748	139	1413	1642
			setupStore	11	5	183	21	8	14

Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState
Benchmark value 1375 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 27 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 35 exceeds gate value 32 for chrome webpack home mean setupStore
Benchmark value 2502 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 296 exceeds gate value 65 for chrome webpack home p95 setupStore
Benchmark value 42 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 1975 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1667 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1666 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 1642 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Sum of mean exceeds: 8ms | Sum of p95 exceeds: 363ms
Sum of all benchmark exceeds: 371ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0%)
ui: 505 Bytes (0.01%)
common: 79 Bytes (0%)

ccharly

As discussed internally, after thinking of this, always ending a trace might not be the best option for errors, but given that we don't have a way to abort the trace, I think that's ok for the moment.

We should have a very low-rate of error for those flows anyway.

feat: add tracing to multi srp features

eb7422f

montelaidev force-pushed the feat/multi-srp-performance-tracing branch from 2912110 to eb7422f Compare March 27, 2025 13:59

montelaidev added the team-accounts-framework Accounts Framework team label Mar 28, 2025

montelaidev marked this pull request as ready for review April 2, 2025 13:52

montelaidev requested a review from a team as a code owner April 2, 2025 13:52

Merge branch 'main' into feat/multi-srp-performance-tracing

d5ad618

Merge branch 'main' into feat/multi-srp-performance-tracing

85092a8

Merge remote-tracking branch 'origin/main' into feat/multi-srp-perfor…

c6c0224

…mance-tracing

darkwing previously approved these changes Apr 28, 2025

View reviewed changes

montelaidev enabled auto-merge April 29, 2025 07:11

ccharly reviewed Apr 29, 2025

View reviewed changes

ui/pages/keychains/reveal-seed.js Outdated Show resolved Hide resolved

ui/components/multichain/create-eth-account/create-eth-account.js Outdated Show resolved Hide resolved

montelaidev added 3 commits May 30, 2025 17:23

Merge remote-tracking branch 'origin/main' into feat/multi-srp-perfor…

2232f76

…mance-tracing

fix: try catch to end trace

7cb995f

fix: move end trace in finally

d30c7f8

montelaidev dismissed darkwing’s stale review via d30c7f8 May 30, 2025 09:47

montelaidev requested a review from ccharly May 30, 2025 11:33

Merge branch 'main' into feat/multi-srp-performance-tracing

d8405c8

ccharly approved these changes Jun 2, 2025

View reviewed changes

vinnyhoward approved these changes Jun 4, 2025

View reviewed changes

montelaidev added this pull request to the merge queue Jun 4, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 4, 2025

montelaidev added this pull request to the merge queue Jun 5, 2025

Merged via the queue into main with commit 6298c39 Jun 5, 2025
272 of 274 checks passed

montelaidev deleted the feat/multi-srp-performance-tracing branch June 5, 2025 13:41

github-actions bot locked and limited conversation to collaborators Jun 5, 2025

metamaskbot added the release-12.21.0 Issue or pull request that will be included in release 12.21.0 label Jun 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add tracing to multi srp features #31354

feat: add tracing to multi srp features #31354

Uh oh!

montelaidev commented Mar 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

metamaskbot commented Mar 27, 2025

Uh oh!

metamaskbot commented Apr 2, 2025 •

edited

Loading

Uh oh!

metamaskbot commented Apr 2, 2025

Uh oh!

metamaskbot commented Apr 3, 2025

Uh oh!

metamaskbot commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented May 30, 2025

Uh oh!

metamaskbot commented May 30, 2025

Uh oh!

ccharly left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

feat: add tracing to multi srp features #31354

feat: add tracing to multi srp features #31354

Uh oh!

Conversation

montelaidev commented Mar 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

metamaskbot commented Mar 27, 2025

Uh oh!

metamaskbot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✨ Files requiring CODEOWNER review ✨

Uh oh!

metamaskbot commented Apr 2, 2025

Uh oh!

metamaskbot commented Apr 3, 2025

Uh oh!

metamaskbot commented Apr 28, 2025

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented May 30, 2025

Uh oh!

metamaskbot commented May 30, 2025

Uh oh!

ccharly left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

montelaidev commented Mar 27, 2025 •

edited

Loading

metamaskbot commented Apr 2, 2025 •

edited

Loading