Skip to content

chore: point to policy review process in policy updated confirmation#41125

Merged
HowardBraham merged 1 commit into
mainfrom
naugtur/policy-review-doc-link-exposure
Mar 27, 2026
Merged

chore: point to policy review process in policy updated confirmation#41125
HowardBraham merged 1 commit into
mainfrom
naugtur/policy-review-doc-link-exposure

Conversation

@naugtur

@naugtur naugtur commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Description

Expanding the successful policy update comment to point to process doc

Open in GitHub Codespaces

Changelog

Related issues

Fixes: null

Manual testing steps

  1. change dependencies enough to make current policy outdated
  2. trigger policy update
  3. observe the comment

Screenshots/Recordings

maybe later

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Only changes GitHub Actions comment text; no changes to policy generation, commits, or runtime code paths.

Overview
When the update-lavamoat-policies workflow successfully updates and commits policies, the PR comment now includes a TIP linking to the docs/lavamoat-policy-review-process.md guidance before seeking reviewer approval, in addition to the existing LavaMoat policy diff reading link.

Written by Cursor Bugbot for commit 94ffeb7. This will update automatically on new commits. Configure here.

@naugtur naugtur requested review from a team, HowardBraham and itsyoboieltr as code owners March 23, 2026 15:32
@naugtur naugtur added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Mar 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbotv2

metamaskbotv2 Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor
Builds ready [b6e31fe]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29126631519301315
total29126631519301315
Confirm Txconfirm_tx603960346047560416047
total603960346047560416047
Bridge User Actionsbridge_load_page22219923715234237
bridge_load_asset_picker23419825420252254
bridge_search_token79873390162836901
total1264118613757513251375
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Standard HomeuiStartup14881276180011115351694
load1229102514799812671409
domContentLoaded1224102114699712621400
domInteractive2918105192586
firstPaint147711233131180291
backgroundConnect22120426212226244
firstReactRender20134662232
initialActions104114
loadScripts101881512559610581200
setupStore1573761824
numNetworkReqs393188164077
Power User HomeuiStartup60352121185143169675114631
load14201214185815114681733
domContentLoaded14001194184214414391686
domInteractive4121278383871
firstPaint274801822212310465
backgroundConnect2756335150403049376410374
firstReactRender28186093150
initialActions107114
loadScripts1144955157113711861415
setupStore1885491839
numNetworkReqs2139539955244314
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2182162201218220
srpButtonToSrpForm93939309393
confirmSrpToPwForm22222202222
pwFormToMetricsScreen16151601616
metricsToWalletReadyScreen17161811818
doneButtonToHomeScreen53851355516552555
openAccountMenuToAccountListLoaded292029092929829262929
total3820379138482038233848
Onboarding New WalletcreateWalletToSocialScreen2202192211221221
srpButtonToPwForm1091051143110114
createPwToRecoveryScreen888088
skipBackupToMetricsScreen38374013940
agreeButtonToOnboardingSuccess16151601616
doneButtonToAssetList4924805009500500
total88687289310893893
Asset DetailsassetClickToPriceChart79738768787
total79738768787
Solana Asset DetailsassetClickToPriceChart1167215232150152
total1167215232150152
Import Srp HomeloginToHomeScreen2391228224717424452471
openAccountMenuAfterLogin614092207892
homeAfterImportWithNewWallet1444260230195921932301
total39572823468283646234682
Send TransactionsopenSendPageFromHome31274162841
selectTokenToSendFormLoaded28253123031
reviewTransactionToConfirmationPage1022847127315111061273
total1098904133814711661338
SwapopenSwapPageFromHome1127717234125172
fetchAndDisplaySwapQuotes269026802703927012703
total2803275728583628252858
🌐 Dapp Page Load Benchmarks

Current Commit: b6e31fe | Date: 3/23/2026

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.03s (±43ms) 🟡 | historical mean value: 1.06s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 724ms (±40ms) 🟢 | historical mean value: 748ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±11ms) 🟢 | historical mean value: 92ms ⬇️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.03s 43ms 1.01s 1.35s 1.05s 1.35s
domContentLoaded 724ms 40ms 704ms 1.01s 736ms 1.01s
firstPaint 79ms 11ms 60ms 168ms 88ms 168ms
firstContentfulPaint 79ms 11ms 60ms 168ms 88ms 168ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@Gudahtt Gudahtt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@naugtur naugtur added this pull request to the merge queue Mar 25, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 25, 2026
@naugtur naugtur force-pushed the naugtur/policy-review-doc-link-exposure branch from b6e31fe to c73cf3d Compare March 26, 2026 09:59
@naugtur naugtur enabled auto-merge March 26, 2026 09:59
@metamaskbotv2

metamaskbotv2 Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor
Builds ready [c73cf3d]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account36929849273406492
total36929849273406492
Confirm Txconfirm_tx6101606761252461206125
total6101606761252461206125
Bridge User Actionsbridge_load_page2312252396239239
bridge_load_asset_picker28826033129298331
bridge_search_token77575479214790792
total1274124313243112941324
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Chrome Browserify Startup Standard HomeuiStartup14871258178110315301699
load1229103114969112711407
domContentLoaded1224102814879012661396
domInteractive3018102202583
firstPaint1336936565172240
backgroundConnect22420325712230247
firstReactRender2316170162334
initialActions106114
loadScripts101382412698810441179
setupStore1477081725
numNetworkReqs393184163880
Chrome Browserify Startup Power User HomeuiStartup55892179178003233624712976
load13471164353926113611625
domContentLoaded13271158353025713361600
domInteractive46213985531150
firstPaint253921650227284460
backgroundConnect2508293141113027311710864
firstReactRender27194862938
initialActions107114
loadScripts1097938324424811051348
setupStore1775281931
numNetworkReqs1538330543166244
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2192182190219219
srpButtonToSrpForm95949619696
confirmSrpToPwForm22222302323
pwFormToMetricsScreen15151601516
metricsToWalletReadyScreen16161701617
doneButtonToHomeScreen57756559916599599
openAccountMenuToAccountListLoaded3046292731649731093164
total3983387140967840334096
Onboarding New WalletcreateWalletToSocialScreen2202182211220221
srpButtonToPwForm1161091267122126
createPwToRecoveryScreen989099
skipBackupToMetricsScreen38383913939
agreeButtonToOnboardingSuccess16151701617
doneButtonToAssetList5125055185518518
total9149119183918918
Asset DetailsassetClickToPriceChart693191228491
total693191228491
Solana Asset DetailsassetClickToPriceChart683393218393
total683393218393
Import Srp HomeloginToHomeScreen2322227523603223442360
openAccountMenuAfterLogin85581081897108
homeAfterImportWithNewWallet2366233923932223932393
total4722458148499647504849
Send TransactionsopenSendPageFromHome302047103747
selectTokenToSendFormLoaded35294464044
reviewTransactionToConfirmationPage1334121914217513711421
total1398126914717814461471
SwapopenSwapPageFromHome13711716519143165
fetchAndDisplaySwapQuotes2695268627081027082708
total2818274828734328522873

Dapp page load benchmarks: data not available.

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 6.84 MiB (100%)
  • ui: 8.35 MiB (100%)
  • common: 11.34 MiB (100%)

@naugtur naugtur force-pushed the naugtur/policy-review-doc-link-exposure branch from c73cf3d to 94ffeb7 Compare March 26, 2026 13:03
@metamaskbotv2

metamaskbotv2 Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor
Builds ready [94ffeb7]
⚡ Performance Benchmarks
👆 Interaction Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Load New Accountload_new_account29628133623285336
total29628133623285336
Confirm Txconfirm_tx6079604861092160956109
total6079604861092160956109
Bridge User Actionsbridge_load_page25321327925269279
bridge_load_asset_picker25321829026277290
bridge_search_token75273276614763766
total1244119712833812791283
🔌 Startup Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Chrome Browserify Startup Standard HomeuiStartup15011248176410215561677
load1237102214549612811409
domContentLoaded1227101614489412751402
domInteractive3016120222792
firstPaint231711368250250411
backgroundConnect21118726815216240
firstReactRender21155372332
initialActions104114
loadScripts103383612129110801201
setupStore1373351623
numNetworkReqs393186163480
Chrome Browserify Startup Power User HomeuiStartup57702200172053283647213178
load12861135185414313341641
domContentLoaded12661132182713113111555
domInteractive40202283635112
firstPaint2421001497161299388
backgroundConnect232429713813278429078401
firstReactRender26174852935
initialActions104113
loadScripts1062944155012310991342
setupStore16684101828
numNetworkReqs1354029552147242
🧭 User Journey Benchmarks
BenchmarkMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P75 (ms)P95 (ms)
Onboarding Import WalletimportWalletToSocialScreen2212212210221221
srpButtonToSrpForm101971094103109
confirmSrpToPwForm23232302323
pwFormToMetricsScreen16161701717
metricsToWalletReadyScreen17171701717
doneButtonToHomeScreen60555667951652679
openAccountMenuToAccountListLoaded3009291431228931123122
total3994390040536040534053
Onboarding New WalletcreateWalletToSocialScreen2172162181218218
srpButtonToPwForm1071061081108108
createPwToRecoveryScreen888088
skipBackupToMetricsScreen38354023940
agreeButtonToOnboardingSuccess15151601616
doneButtonToAssetList60747973398673733
total99385911189910611118
Asset DetailsassetClickToPriceChart795793138993
total795793138993
Solana Asset DetailsassetClickToPriceChart694992178692
total694992178692
Import Srp HomeloginToHomeScreen2409235524945324112494
openAccountMenuAfterLogin72461082697108
homeAfterImportWithNewWallet1312462259699124522596
total393129045662118250535662
Send TransactionsopenSendPageFromHome34254474144
selectTokenToSendFormLoaded30233753637
reviewTransactionToConfirmationPage1030884124113110691241
total1095953130813011401308
SwapopenSwapPageFromHome913415042125150
fetchAndDisplaySwapQuotes2695268627101027052710
total2786272028404728352840

Dapp page load benchmarks: data not available.

Bundle size diffs
  • background: 58 Bytes (0%)
  • ui: 5 Bytes (0%)
  • common: 20 Bytes (0%)

@naugtur naugtur added this pull request to the merge queue Mar 26, 2026
@sonarqubecloud

Copy link
Copy Markdown

@HowardBraham HowardBraham removed this pull request from the merge queue due to a manual request Mar 26, 2026
@HowardBraham HowardBraham added this pull request to the merge queue Mar 27, 2026
Merged via the queue into main with commit 50a000c Mar 27, 2026
393 of 395 checks passed
@HowardBraham HowardBraham deleted the naugtur/policy-review-doc-link-exposure branch March 27, 2026 18:03
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2026
@metamaskbot metamaskbot added the release-13.26.0 Issue or pull request that will be included in release 13.26.0 label Mar 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-13.26.0 Issue or pull request that will be included in release 13.26.0 size-XS skip-release-validation team-lavamoat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants