test(e2e): share Android WebView helpers via multi-platform WebView API - #33874
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ty in checkResultSpan
…r transient issues
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2de4a17. Configure here.
…in checkResultSpan
…ask/metamask-mobile into e2e/android-webview-shared-helpers
10 tasks
GuillaumeRx
requested changes
Jul 28, 2026
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - skip-smart-e2e-selection label found All E2E tests pre-selected. |
|
GuillaumeRx
requested changes
Jul 28, 2026
GuillaumeRx
approved these changes
Jul 28, 2026
cmd-ob
enabled auto-merge
July 28, 2026 13:22
vivek-consensys
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Android WebView tap/fill/read lived behind snaps-only helpers and
TestSnapshad manyisAndroidAppium()branches. This PR introduces a multi-platformWebViewframework facade (tapById/fillById/readTextById) that routes Android Appium toAndroidWebViewNativeand iOS Appium/Detox to the existing web-context + Gestures path.TestSnapsnow uses that single API, snaps helpers keep only scroll labels + load wait, and tab cleanup moves behindBrowser.navigateToURL({ closeAllTabsIfOpen }).Changelog
CHANGELOG entry: null
Related issues
Refs: #32877
Manual testing steps
N/A — E2E framework refactor only; no product UI changes. Validate by running existing Appium snap smoke specs (Android + iOS) and confirming Detox snap smoke still exercises
TestSnapsvia the sharedWebViewpath.Screenshots/Recordings
N/A — test framework / page-object refactor with no user-facing UI changes.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Made with Cursor