Skip to content

fix: Hide preinstalled example Snap#4068

Merged
FrederikBolding merged 1 commit into
mainfrom
fb/hide-preinstalled-example-snap
Jul 8, 2026
Merged

fix: Hide preinstalled example Snap#4068
FrederikBolding merged 1 commit into
mainfrom
fb/hide-preinstalled-example-snap

Conversation

@FrederikBolding

@FrederikBolding FrederikBolding commented Jul 7, 2026

Copy link
Copy Markdown
Member

The previous versions of the preinstalled example Snap had omitted hidden, this results in it actually being hidden from the UI, which some E2Es assert against. This PR restores that behaviour and makes it explicit.


Note

Low Risk
Single boolean in an example snap config; no production snap controller or security behavior changes.

Overview
Sets preinstalled.hidden to true in the preinstalled example’s snap.config.ts so the snap stays out of the normal UI, matching how older builds behaved when the flag was omitted and what E2E tests expect.

No runtime logic changes—only explicit config for the example package.

Reviewed by Cursor Bugbot for commit b87e128. Bugbot is set up for automated code reviews on this repo. Configure here.

@FrederikBolding FrederikBolding marked this pull request as ready for review July 7, 2026 14:49
@FrederikBolding FrederikBolding requested a review from a team as a code owner July 7, 2026 14:49
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.59%. Comparing base (d4cf201) to head (b87e128).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4068   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files         428      428           
  Lines       12484    12484           
  Branches     1975     1975           
=======================================
  Hits        12309    12309           
  Misses        175      175           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FrederikBolding FrederikBolding added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit ddc6a4a Jul 8, 2026
135 checks passed
@FrederikBolding FrederikBolding deleted the fb/hide-preinstalled-example-snap branch July 8, 2026 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants