Skip to content

If switch on for multiple file add the sort column to the database#55

Merged
discordier merged 1 commit intoMetaModels:hotfix/order-fieldfrom
ContaoBlackForest-archive:hotfix/order-field-switch-on-multiple
Dec 1, 2017
Merged

If switch on for multiple file add the sort column to the database#55
discordier merged 1 commit intoMetaModels:hotfix/order-fieldfrom
ContaoBlackForest-archive:hotfix/order-field-switch-on-multiple

Conversation

@baumannsven
Copy link
Copy Markdown
Member

@baumannsven baumannsven commented Apr 9, 2017

The file attribute use permanently the virtual sort attribute. We must have the virtual sort attribute only the file attribute works in the multiple mode.

@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Apr 10, 2017

@baumannsven: have you a reference issue?

@baumannsven
Copy link
Copy Markdown
Member Author

@zonky2 What do you mean with reference item?

This can be tested.

Please test update handler (runonce) too. For the update handler test you must delete the columns ending with sort in all mm* tables.

@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Apr 11, 2017

@baumannsven sorry - I mean Issue ... or add description

@baumannsven
Copy link
Copy Markdown
Member Author

No exist in issue for this

@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Apr 11, 2017

or add description

@baumannsven
Copy link
Copy Markdown
Member Author

If merge this pull request you must use MetaModels/core#1107 to.

@zonky2
Copy link
Copy Markdown
Contributor

zonky2 commented Apr 11, 2017

note: think about an exception if column <file-attribute-column>__sort already exist...

@baumannsven
Copy link
Copy Markdown
Member Author

For works correctly by sort manual, must be merge this MetaModels/attribute_translatedfile#14

@zonky2 zonky2 added this to the 2.0.1 milestone Apr 25, 2017
@discordier discordier modified the milestones: 2.0.1, Future Dec 1, 2017
@discordier discordier merged commit 9616bbf into MetaModels:hotfix/order-field Dec 1, 2017
discordier added a commit that referenced this pull request Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants