Updated FromFile() to remove unused TextureRegion #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed redundant TextureRegion region because it's not used in the Method.
Collaborator
|
Thoughts @AristurtleDev ? Also, if merged the MonoGame.Samples project will also need updating |
Contributor
|
@SimonDarksideJ should be good to have this line of code removed. I believe it was left over from something that was being done in the initial stages of writing the chapter and forgot to remove it. |
AristurtleDev
approved these changes
Nov 3, 2025
AristurtleDev
added a commit
to AristurtleDev/MonoGame.Samples
that referenced
this pull request
Nov 3, 2025
This is related to the PR in the tutorial documentation at MonoGame/docs.monogame.github.io#193
Contributor
|
@jordanlhunt i created PR MonoGame/MonoGame.Samples#99 to remove it from the samples as well |
SimonDarksideJ
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed redundant "TextureRegion region" because it's not used in the Method.