Port library settings from Core - #193
Merged
RadicalMuffinMan merged 4 commits intoAug 7, 2026
Merged
Conversation
Collaborator
|
I don't have multiple libraries of the same type to test... |
Collaborator
Author
|
Ship it and fix it later if it doesn't work then i guess lol |
Collaborator
Author
|
you can test the other ones though :p |
Collaborator
|
looking at the changes in this pr, I see you added the settings, but do they actually do anything? you didn't change anything else in the code to use those settings for anything |
Collaborator
Author
|
...you are right, hold please 🤣 |
Implement UI handling for ported library settings in Roku components: - Wire ui.library.showMediaDetails and ui.library.hideBackdrops in VisualLibraryScene.bs - Wire ui.library.useDetailedSubHeadings in GridItem.bs
Collaborator
Author
|
Forgot to commit the important files, mb haha |
Collaborator
|
what about mergeRecentRowsByType |
…ubHeadings, and hideBackdrops logic - Added mergeRecentRowsByType support to group home screen Recently Added rows by collection type - Added itemIds support to LoadItemsTask for fetching and merging items across multiple libraries - Added showMediaDetails toggling for library detail header bars in VisualLibraryScene - Added useDetailedSubHeadings toggling for grid poster sub-headings in GridItemMedium - Added hideBackdrops support to suppress fanart images while browsing in setBackgroundWithQueue
Collaborator
Author
|
Now try 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Ports Library preferences from Moonfin-Core and Moonbase to Roku:
Related Issues
Link related issues or tickets separated by commas.
Type of Change
Changes Made
List the key changes included in this PR.
Testing
Describe how this change was tested.
Test Steps
Settings Menu Verification:
Test Show Media Details:
Test Hide Backdrops while Browsing:
Test Use Detailed Sub-Headings:
Test Merge Recently Added Libraries by Type:
Screenshots (if applicable)
Include screenshots or recordings for UI changes.
Checklist