Skip to content

Migrate to gha's check-new-line-breaks reusable workflow - #703

Merged
d-morrison merged 3 commits into
mainfrom
chore/migrate-to-gha-check-new-line-breaks
Jul 25, 2026
Merged

Migrate to gha's check-new-line-breaks reusable workflow#703
d-morrison merged 3 commits into
mainfrom
chore/migrate-to-gha-check-new-line-breaks

Conversation

@d-morrison

@d-morrison d-morrison commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Closes #702

WIP — opened up front to claim the issue; implementing now.

Generated by Claude Code

claude added 2 commits July 25, 2026 01:22
@claude
start: migrate to gha check-new-line-breaks (closes #702)
dbe82c1
@claude
Migrate to gha's check-new-line-breaks reusable workflow
22ac567 
Retires the local scripts/check-new-line-breaks.py in favor of
d-morrison/gha/.github/workflows/check-new-line-breaks.yml@v2 (gha#300),
which was built specifically to replace it. Closes #702.
@d-morrison
d-morrison marked this pull request as ready for review July 25, 2026 01:26
Copilot AI review requested due to automatic review settings July 25, 2026 01:26
Copilot AI reviewed Jul 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

This comment has been minimized.

Sign in to view
claude[bot]
claude Bot reviewed Jul 25, 2026
View reviewed changes
Comment thread .github/workflows/validate.yml Outdated
claude[bot]
claude Bot reviewed Jul 25, 2026
View reviewed changes
Comment thread .github/workflows/validate.yml
@claude
Address review: SHA-pin gha reusable workflow ref, document push-skip…
997d5a9 
… behavior

Matches the file's existing SHA-pin convention for d-morrison/gha
references, and documents why no event_name guard is needed: the
reusable workflow's own base-ref input already makes non-PR runs skip
cleanly.
Copilot AI review requested due to automatic review settings July 25, 2026 01:30
@claude claude Bot mentioned this pull request Jul 25, 2026
Merged
Copilot AI reviewed Jul 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @d-morrison's task in 53s —— View job

Verdict: Ready for merge

Both findings from the prior round are resolved in 997d5a9:

  1. SHA pin ✅ — validate.yml:41 now pins to @209bfb76bd412aa10d4d56a809d791a6dc8f10df # v2, gha#300, matching the file's existing convention (actions/checkout@..., lint-qmd@...).

  2. Push-skip behaviour ✅ — The new-line-breaks job comment now explicitly documents why no event_name guard is needed: the reusable workflow receives github.event.pull_request.base.sha on PRs and '' otherwise, and skips cleanly on the empty value. That's a concrete, verifiable explanation, not just a hand-wave.

No new issues in the latest commit. The dont-reinvent-wheel.md prose uses @v2 symbolically in a historical anecdote — fine in prose, the actual workflow reference is SHA-pinned.

@d-morrison
d-morrison merged commit 8a9332b into main Jul 25, 2026
11 checks passed
@d-morrison
d-morrison deleted the chore/migrate-to-gha-check-new-line-breaks branch July 25, 2026 01:40
This was referenced Jul 25, 2026
Merged
Closed
@claude claude Bot mentioned this pull request Jul 25, 2026
Merged
This was referenced Jul 25, 2026
Open
Open
Merged
Open
@dem-extra1 dem-extra1 mentioned this pull request Jul 29, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@claude claude[bot] claude[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate to gha's check-new-line-breaks reusable workflow, retire local script

3 participants

@d-morrison @claude