Skip to content

docs: register ai-config as a check-new-line-breaks consumer - #302

Merged
d-morrison merged 2 commits into
mainfrom
docs/revdeps-check-new-line-breaks
Jul 25, 2026
Merged

docs: register ai-config as a check-new-line-breaks consumer#302
d-morrison merged 2 commits into
mainfrom
docs/revdeps-check-new-line-breaks

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

d-morrison/ai-config#702/#703 migrates from its own local
scripts/check-new-line-breaks.py to this repo's new check-new-line-breaks
reusable workflow (gha#300). REVDEPS.md says "If your repo calls a gha
workflow, please open a PR adding it below" — registering it here.

No code change; REVDEPS.md only.


Generated by Claude Code

Copilot AI review requested due to automatic review settings July 25, 2026 01:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Jul 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread REVDEPS.md Outdated
@claude

claude Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Code review

Reviewed this one-line REVDEPS.md change (registering d-morrison/ai-config as a consumer of check-new-line-breaks).

Fact-checked the citations in the added text:

  • gha#300 — confirmed merged, adds the check-new-line-breaks composite/reusable workflow.
  • ai-config#702 — confirmed open issue describing the planned migration.
  • ai-config#703 — confirmed open and still WIP/unmerged as of this review.

One finding posted inline: the entry lists check-new-line-breaks in the Workflows used column, but ai-config isn't actually calling it yet — ai-config#703 (the migration PR) is still open, and a raw fetch of ai-config's main branch shows .github/workflows/validate.yml still invoking the local scripts/check-new-line-breaks.py. REVDEPS.md's own registration instructions and the existing qwt row's precedent (workflows only added to Workflows used once the migrating PR is merged, with not-yet-live ones called out separately in Notes) suggest this entry is premature. See the inline comment for the specific suggestion.

No other issues found — the added prose is otherwise accurate, well-cited, and consistent with the table's existing style (no AI-tell language, no broken links, no CLAUDE.md formatting violations).

Verdict

Needs more work — hold until ai-config#703 merges (or move check-new-line-breaks to the Notes column as pending) before merging this registration.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Review posted. Summary:

PR #302 (d-morrison/gha) registers d-morrison/ai-config as a consumer of the new check-new-line-breaks workflow in REVDEPS.md.

Finding (posted inline on REVDEPS.md:31): The registration is premature. I fact-checked the cited references: gha#300 (merged, adds the workflow) checks out, but ai-config#703 — the actual migration PR — is still open/WIP, and a raw fetch of ai-config's main branch confirms validate.yml still calls the old local script, not the new gha reusable workflow. REVDEPS.md's own present-tense registration instructions, plus the qwt row's precedent (workflows only added to the list once merged, pending ones noted separately), suggest this entry should wait until ai-config#703 merges.

Verdict

Needs more work

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $1.0220 (review) — run

ai-config#703 (the migration PR) hasn't merged yet, so ai-config isn't
actually calling check-new-line-breaks from main. Follow the qwt row's
precedent: list it as pending in Notes, not in Workflows used, until
the migration PR merges.
Copilot AI review requested due to automatic review settings July 25, 2026 01:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished reviewView run


Code review

This is a follow-up review round on PR #302. The diff has changed since my last review (comment posted 2026-07-25T01:30:54Z, #302).

Prior finding resolved. My previous inline comment on REVDEPS.md:31 flagged that the entry listed check-new-line-breaks in the Workflows used column even though ai-config wasn't actually calling it yet (migration PR ai-config#703 still open). The current diff (commit 8ce38109a7e0264f73b8c7b939c3642c3edfdab8) fixes this exactly as suggested: check-new-line-breaks has been removed from the Workflows used cell (still reads quarto-publish (@v2), preview, preview-deploy, cleanup-pr-previews) and is now called out in the Notes column as pending, citing ai-config#702/#703 — matching the qwt row's existing precedent for not-yet-implemented workflows.

Re-verified the citations in the new text:

  • gha#300 (merged) — its own PR body confirms check-new-line-breaks was "Ported from d-morrison/ai-config's scripts/check-new-line-breaks.py" (ai-config#682/#684), supporting the new parenthetical claim that it was "built ... specifically to replace ai-config's own local script of the same purpose."
  • ai-config#702 — confirmed open.
  • ai-config#703 — confirmed still open/unmerged.
  • Raw-fetched ai-config's main branch .github/workflows/validate.yml just now — still invokes the local scripts/check-new-line-breaks.py, confirming the "pending" framing is still accurate.

No new issues found. The updated row is well-formed Markdown (no broken table syntax), free of AI-tell language, and consistent with the table's existing style.

Verdict

Ready for merge — the prior finding (premature registration) is fully addressed; no new issues introduced.

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.5163 (review) — run

@d-morrison
d-morrison merged commit fec18d8 into main Jul 25, 2026
28 checks passed
@d-morrison
d-morrison deleted the docs/revdeps-check-new-line-breaks branch July 25, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants