build: fixes for cr-destol gradle build and cleanup - #55
Conversation
Terasology has used more the robust includeBuild for library dependencies for some time now.
|
Warning Review limit reached
Next review available in: 48 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGradle configuration now resolves destination-module dependencies from Terasology Artifactory, Maven Central, and JBoss repositories. Module inclusion is simplified to always use the ChangesGradle build wiring
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cr-destsol/build.gradle.kts (1)
17-20: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winRestrict the JBoss repository to required modules.
cr-core/build.gradle.kts:40-50filters this repository toorg:jpastebin, butcr-destsolenables the entire public JBoss repository. Mirror that filter here, or explicitly list the additional required modules, to avoid unnecessarily broad dependency resolution.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@cr-destsol/build.gradle.kts` around lines 17 - 20, Restrict the JBoss Maven repository declared in cr-destsol’s repositories configuration to the required modules instead of allowing the entire public repository. Mirror the existing org:jpastebin content filter used by cr-core, or explicitly include only the additional dependencies needed by cr-destsol.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@cr-destsol/build.gradle.kts`:
- Around line 17-20: Restrict the JBoss Maven repository declared in
cr-destsol’s repositories configuration to the required modules instead of
allowing the entire public repository. Mirror the existing org:jpastebin content
filter used by cr-core, or explicitly include only the additional dependencies
needed by cr-destsol.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 58316720-d28e-4a16-bbc9-51946278d3a1
📒 Files selected for processing (2)
cr-destsol/build.gradle.ktssettings.gradle.kts
The pull request fixes the
cr-destolbuild by adding back the missingrepositoriesblock. It also removes some obsolete Terasology specific configuration logic fromsettings.gradle.ktsthat has not been used in a long time, since Terasology moved to using more robust Gradle composite builds.