chore: replace drain with poll for queue for GameThread#4880
Open
chore: replace drain with poll for queue for GameThread#4880
Conversation
7a4a090 to
5b79ac0
Compare
Contributor
|
this happens only one time per tick. what about adding process during iteration ( multi-thread behavior, like process adds another processes)? |
Member
Author
|
lot of this logic is bound to the main game thread @DarkWeird :? |
Contributor
It should be bound to main game thread. Otherwise you can not use gamethread class :) I afraid this things:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes an extra array allocation when we process the processing the pending runnable