refactor: merge game info into home#189
Conversation
this might be the point at which we add the react/router dep... |
* update patch versions of deps
| className="font-weight-bold btn btn-lg btn-success home-btn" | ||
| > | ||
| <Link to="/game" className="link-about"> | ||
| <Link to="#about" className="link-about"> |
There was a problem hiding this comment.
Looks like we don't need the gatsby-plugin-anchor-links after all, I just needed to put the id on the row instead of the section as the section didn't do anything with it - we could also consider adding logic to add the id to the section div such that basically any section can be linked to.
Also, Link in comparison to AnchorLink doesn't scroll smoothly, but that would also be something which - if we want it - can be achieved using a react plugin like smooth-scroll instead of with a gatsby plugin.
| </div> | ||
| </Section> | ||
|
|
||
| <Row id="about" className="justify-content-center"> |
There was a problem hiding this comment.
One aspect I don't like so much is that when we link to this, the section caption is not visible. I believe this is due to the height of our header obscuring a part of the page not being considered when jumping to the anchor. Any idea that currently comes to my mind on how to fix it would be an ugly hack, so I'm inclined to accept it for now until we have a good idea on how to solve this.
…title) All elements with `ts-anchor` have a scroll margin defined to adjust for the fixed header. The `Section` automatically assigns this class to the heading element.
|
Kudos, SonarCloud Quality Gate passed!
|
2 participants
Action items before merging