Skip to content

chore: update texts#193

Merged
skaldarnar merged 41 commits intomasterfrom
chore/update-texts
Jan 14, 2023
Merged

chore: update texts#193
skaldarnar merged 41 commits intomasterfrom
chore/update-texts

Conversation

@jdrueckert
Copy link
Copy Markdown
Member

@jdrueckert jdrueckert commented Jan 8, 2023

Depends on #189

Related PRs

Comment thread src/components/About/About.jsx Outdated
Comment thread src/components/About/About.jsx Outdated
Comment thread src/components/About/About.jsx Outdated
Comment thread src/components/About/About.jsx Outdated
Comment thread src/components/About/About.jsx Outdated
@jdrueckert jdrueckert marked this pull request as ready for review January 9, 2023 21:15
Comment thread src/components/Home/Index.jsx Outdated
Comment thread src/components/Home/Index.jsx Outdated
<Button type="button" color="primary" size="lg">
<Link to="#about-us" className="link-about">
Learn More
Learn more
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's note somewhere a little action item: Decide whether we want to use title case on buttons or not 🙃 I think I recently put "Load More" on a button... 🤔

Comment thread src/components/Home/Index.jsx Outdated
in 2011. Over the years it has been a playground for different kinds
of technical experiments and proof of concepts. The community
strives to make Terasology a stable platform for various types of
gameplay settings in a voxel world. The contributors are a diverse
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it on purpose that we have the sentence on "diverse mix" both here and further down on the page now?

Copy link
Copy Markdown
Member

@skaldarnar skaldarnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The texts look good to me, and I really like the image with the deer and sheep as background for the community highlight.

Given that the other PR for the Getting Started page is ready as well, I'd suggest to merge that first and adjust the links in this PR to point to the right page and section.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@skaldarnar skaldarnar merged commit 79be351 into master Jan 14, 2023
@skaldarnar skaldarnar deleted the chore/update-texts branch January 14, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants