BACK-584 - Keep vim keys inside the list at navigation boundaries - #866
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #768. Supersedes #770's config-key approach per maintainer decision.
At list/board boundaries,
j/kpreviously handed focus to the search input (deliberate in BACK-399, surprising for vim users). Decided behavior, no new config key:j/know stop at boundaries (no wrap, no handoff) while the arrow keys keep the search handoff, on the task list, the detail pane, and the board including empty columns;/and Ctrl+F are unchanged.Implementation splits the shared bindings into arrow/vim families with one shared boundary resolver; the board's two screen handlers collapse into one (net −23 lines in board.ts). Filter popups and pickers keep circular wrap for both families.
Verification: behavior tests driven by real key events with a mutation control (forcing vim to hand off fails 5 tests), plus real-PTY passes on all surfaces whose control scripts fail against pre-fix main. Full suite 1951 pass / 0 fail. Independently reviewed with no blocking findings, including a fork-source analysis confirming no double-scroll in the detail pane and intact picker wrapping.