[pull] master from unoplatform:master#274
Merged
pull[bot] merged 5 commits intoMu-L:masterfrom Mar 24, 2021
Merged
Conversation
…when theme changes Since Uno doesn't support theme-binding to TargetNullValue, and it's not a common use case, apply the workaround of setting the PlaceholderForeground value in the style, and adjusting the visual states for disabled, etc.
It helps with colors
Using a custom control for the test doesn't work here because then it no longer uses the Fluent style (implicit style resolution is based on the exact type, the DefaultStyleKey is ignored).
fix: Ensure Fluent style placeholders in ComboBox and TextBox update when theme changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )