fix: color triggers now work inside 'only pass matches' trigger groups#9442
Open
vadi2 wants to merge 1 commit into
Open
fix: color triggers now work inside 'only pass matches' trigger groups#9442vadi2 wants to merge 1 commit into
vadi2 wants to merge 1 commit into
Conversation
Assisted-by: Claude:claude-fable-5 Signed-off-by: Vadim Peretokin <vadim.peretokin@mudlet.org>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
|
Reviews (1): Last reviewed commit: "Fix: color trigger under a filter parent..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Motivation for adding to Mudlet
Filter chains are the standard way to scope triggers, and color patterns silently did nothing inside them.
Other info (issues closed, discussion etc)
Fixes #8198
Known limitation: children of multiline filter parents still can't use color patterns (a multiline match spans several lines, so no single line applies).
Test case: create a perl-regex trigger
^(hello world)$with "only pass matches" ticked, nest a color trigger (foreground ANSI yellow) under it withecho("CHILD FIRED\n"), thenlua feedTriggers("\27[33mhello world\27[0m\n")- the child fires. Covered by the new ColorTriggerFilterChildTest (ctest).trimmed.mp4