Skip to content

ECT fixes: DA cycling, spin-up caching, 1e-14 perturbation, GPU workflow - #14

Merged
cenamiller merged 1 commit into
masterfrom
feature-ci-ect-debug-perturbation
Mar 26, 2026
Merged

ECT fixes: DA cycling, spin-up caching, 1e-14 perturbation, GPU workflow#14
cenamiller merged 1 commit into
masterfrom
feature-ci-ect-debug-perturbation

Conversation

@cenamiller

Copy link
Copy Markdown
Collaborator

Summary

  • DA cycling fix: Enable config_do_DAcycling on restart so theta perturbations propagate into the prognostic theta_m field, fixing bitwise-identical ensemble outputs
  • Spin-up caching: Use a stable cache key for the 24h spin-up restart file, avoiding expensive re-runs on every commit
  • Perturbation magnitude: Set to 1e-14 per the paper recommendation (Price-Broncucia et al. 2025); verified that theta is stored as float64 in restart files
  • GPU subset workflow: New test-gpu.yml for NVHPC/MPICH/SMIOL cuda-vs-nogpu comparison on CIRRUS
  • Misc: YAML parse fix for inline Python in composite action, Git LFS for restart push, Copilot review fixes

Validation

  • 3-member test ensemble succeeded with 1e-14 perturbation (run #23611206904)
  • Post-run theta means diverge across members, confirming perturbation propagation
  • Ready for full 200-member ensemble generation once merged

Copilot AI review requested due to automatic review settings March 26, 2026 19:08
@cenamiller
cenamiller merged commit 2709c9a into master Mar 26, 2026
17 of 22 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ECT 120 km test-case configuration to use the paper-recommended perturbation magnitude, aligning the CI ECT setup with the documented methodology.

Changes:

  • Set ECT_PERTURB_MAGNITUDE from 1e-5 to 1e-14 in the ECT 120 km config.env.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cenamiller
cenamiller deleted the feature-ci-ect-debug-perturbation branch March 26, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants