ECT fixes: DA cycling, spin-up caching, 1e-14 perturbation, GPU workflow - #14
Merged
Merged
Conversation
Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Updates the ECT 120 km test-case configuration to use the paper-recommended perturbation magnitude, aligning the CI ECT setup with the documented methodology.
Changes:
- Set
ECT_PERTURB_MAGNITUDEfrom1e-5to1e-14in the ECT 120 kmconfig.env.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_do_DAcyclingon restart so theta perturbations propagate into the prognostictheta_mfield, fixing bitwise-identical ensemble outputs1e-14per the paper recommendation (Price-Broncucia et al. 2025); verified thatthetais stored as float64 in restart filestest-gpu.ymlfor NVHPC/MPICH/SMIOL cuda-vs-nogpu comparison on CIRRUSValidation
1e-14perturbation (run #23611206904)