Skip to content

Fix operator cards db layout in ekomark#231

Merged
felixhekhorn merged 1 commit intomasterfrom
fix-operator-card-db
Mar 24, 2023
Merged

Fix operator cards db layout in ekomark#231
felixhekhorn merged 1 commit intomasterfrom
fix-operator-card-db

Conversation

@felixhekhorn
Copy link
Contributor

  • thanks to @t7phy for detecting this
  • no idea how this worked so far e.g. here:
    "interpolation_xgrid": lambertgrid(60).tolist(),
  • somehow sqlite mapped the name interpolation_xgrid present in the card update to the name xgrid present in the DB
  • as already said let's stick to the old names inside ekomark for the time (but only there)

@felixhekhorn felixhekhorn added bug Something isn't working benchmarks Benchmark (or infrastructure) related labels Mar 24, 2023
@alecandido
Copy link
Member

somehow sqlite mapped the name interpolation_xgrid present in the card update to the name xgrid present in the DB

If sqlite did something (i.e. SQLAlchemy) it is actually using positional arguments, without checking the name.

Otherwise we should have done it somewhere ourselves :)

@felixhekhorn felixhekhorn merged commit 4c8030f into master Mar 24, 2023
@felixhekhorn felixhekhorn deleted the fix-operator-card-db branch March 24, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarks Benchmark (or infrastructure) related bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants