Bump the Node 20 actions that have no behavior change - #2102
Merged
Conversation
Runners already force these onto Node 24, so this only clears the deprecation warnings. Checked each release for breaking changes: - actions/cache v4 -> v6: needs runner >= 2.327.1; ours report 2.336.0. - actions/download-artifact v4 -> v8: v5's breaking change applies to downloads by artifact ID; pages.yml downloads by name. - actions/upload-artifact v4 -> v7, dorny/paths-filter v3 -> v4, poseidon/wait-for-status-checks v0.6.0 -> v0.7.0: node24 runtime only. step-security/changed-files is deliberately left at v46.0.5 and bumped separately, since the gating depends on its files_yaml group outputs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughGitHub Actions references were updated across the cache composite action, PR workflows, example tests, and Pages workflow. Cache, status-check, artifact, path-filter, and artifact-download actions now use newer versions. ChangesGitHub Actions updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2102 +/- ##
==========================================
- Coverage 78.60% 78.08% -0.52%
==========================================
Files 522 522
Lines 60167 60167
==========================================
- Hits 47294 46982 -312
- Misses 12873 13185 +312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kevalmorabia97
added a commit
that referenced
this pull request
Aug 7, 2026
### What does this PR do? Type of change: CI/CD maintenance Last of the [Node 20](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/) actions: `step-security/changed-files` v46.0.5 → v47.0.5, in `_pr_gate.yml`, `example_tests.yml` and `unit_tests.yml`. Deliberately separate from #2102. Every gate in the repo runs through this action, and the example lanes depend on its `files_yaml` per-group outputs plus `any_modified` semantics. v47 has no release notes describing output behavior, and the upstream v47 notes are dependency bumps only — so this is the one bump I could not clear from a changelog. On its own, any gating regression is unambiguous. What I did verify at `v47.0.5`: - `micromatch` is still `^4.0.5` — the matcher the lane patterns were validated against - `files`, `files_ignore`, `files_yaml`, `files_ignore_yaml` are all still inputs - `any_modified`, `any_changed`, `changed_keys` are all still documented outputs ### Testing Static checks above. The behavior that matters cannot be proven from this PR: it changes workflow files, which are in the `common` group, so **every lane runs regardless** of whether gating still works. I plan to confirm with a throwaway probe PR against this branch — a docs-only change must run nothing, and a single-example change must run exactly one lane — the same method that caught the two ignore bugs fixed in #2101. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A — CI configuration - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A - Did you get Claude approval on this PR?: ❌ — not yet run <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated pull-request file-change checks to use the latest available file-detection action. * Applied the update consistently across example-test and unit-test workflows. * Improved consistency and reliability across automated pull-request validation checks without changing application behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
kevalmorabia97
added a commit
that referenced
this pull request
Aug 7, 2026
### What does this PR do? Type of change: CI/CD maintenance #2102 and #2103 bumped every action this repo references *directly*, but Node 20 annotations still appear — e.g. [this run on #2103](https://github.com/NVIDIA/Model-Optimizer/actions/runs/31170982088?pr=2103): > The following actions target Node.js 20 but are being forced to run on Node.js 24: `actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea` We never reference `github-script`. It comes in transitively through `codecov/codecov-action`: | codecov-action | bundled github-script | runtime | |---|---|---| | `@v5` (= v5.5.5) | `60a0d830…` | **node20** | | `@v6.0.2` / `@v7.0.0` | `ed597411…` | node24 | Bumps all four call sites (`unit_tests`, `gpu_tests`, `regression_tests`, `_example_tests_runner`) to `@v7`. Checked: v6's notes call out node24 support as the only breaking aspect — the same pattern as the bumps in #2102 — and our runners report 2.336.0. The inputs used here (`token`, `files`, `flags`, `fail_ci_if_error`, `verbose`) all still exist in v7. A scan of every referenced action, direct and one level transitive, now finds no node20 runtimes left. ### Testing Coverage upload runs in every unit, gpu, regression and example job, so CI exercises this broadly. Worth checking that coverage still lands in Codecov rather than only that the step is green — `fail_ci_if_error: false` means an upload failure would not turn the job red. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A — CI configuration - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A - Did you get Claude approval on this PR?: ❌ — not yet run <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated automated test workflows to use the latest coverage reporting action. * Improved compatibility and reliability of coverage report uploads across example, GPU, regression, and unit tests. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: CI/CD maintenance
Clears the Node 20 deprecation warnings. The runner already forces these onto Node 24, so this changes what the actions declare, not how they run.
actions/cacheactions/download-artifactpages.ymldownloads byname: docs-htmlactions/upload-artifactdorny/paths-filterposeidon/wait-for-status-checksstep-security/changed-filesstays at v46.0.5 and is bumped in a separate PR: the lane gating depends on itsfiles_yamlgroup outputs andany_modifiedsemantics, and v47 ships no release notes covering them. Splitting keeps a gating regression attributable.Testing
actions/cacheis exercised by every GPU job throughcache-extensions; thepages.ymlthree are exercised by the docs build. Worth watching on this PR: cache hit rate rather than just success, since a silent cache-key change costs build time without failing.Before your PR is "Ready for review"
CONTRIBUTING.md: N/ASummary by CodeRabbit