Skip to content

Bump codecov-action to v7, the last Node 20 warning - #2110

Merged
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/bump-codecov-node24
Aug 7, 2026
Merged

Bump codecov-action to v7, the last Node 20 warning#2110
kevalmorabia97 merged 1 commit into
mainfrom
kmorabia/bump-codecov-node24

Conversation

@kevalmorabia97

@kevalmorabia97 kevalmorabia97 commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Type of change: CI/CD maintenance

#2102 and #2103 bumped every action this repo references directly, but Node 20 annotations still appear — e.g. this run on #2103:

The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@60a0d83039c74a4aee543508d2ffcb1c3799cdea

We never reference github-script. It comes in transitively through codecov/codecov-action:

codecov-action bundled github-script runtime
@v5 (= v5.5.5) 60a0d830… node20
@v6.0.2 / @v7.0.0 ed597411… node24

Bumps all four call sites (unit_tests, gpu_tests, regression_tests, _example_tests_runner) to @v7.

Checked: v6's notes call out node24 support as the only breaking aspect — the same pattern as the bumps in #2102 — and our runners report 2.336.0. The inputs used here (token, files, flags, fail_ci_if_error, verbose) all still exist in v7. A scan of every referenced action, direct and one level transitive, now finds no node20 runtimes left.

Testing

Coverage upload runs in every unit, gpu, regression and example job, so CI exercises this broadly. Worth checking that coverage still lands in Codecov rather than only that the step is green — fail_ci_if_error: false means an upload failure would not turn the job red.

Before your PR is "Ready for review"

  • Is this change backward compatible?: ✅
  • If you copied code from any other sources or added a new PIP dependency, did you follow guidance in CONTRIBUTING.md: N/A
  • Did you write any new necessary tests?: N/A — CI configuration
  • Did you update Changelog?: N/A
  • Did you get Claude approval on this PR?: ❌ — not yet run

Summary by CodeRabbit

  • Chores
    • Updated automated test workflows to use the latest coverage reporting action.
    • Improved compatibility and reliability of coverage report uploads across example, GPU, regression, and unit tests.

#2102 and #2103 covered every action this repo references directly, but the
warning persisted because codecov-action@v5 pulls in
actions/github-script@60a0d830 (node20) internally. v6.0.2 and v7.0.0 both
move to github-script@ed597411 (node24).

v6's release notes call out node24 support as the only breaking aspect,
matching the other bumps in #2102; our runners report 2.336.0. The inputs
used here -- token, files, flags, fail_ci_if_error, verbose -- are all still
present in v7.

A scan of every referenced action, direct and one level transitive, now
reports no remaining node20 runtimes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97
kevalmorabia97 requested a review from a team as a code owner August 7, 2026 11:45
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6752f775-25c5-4a8d-b3f0-171cb0bcdb9b

📥 Commits

Reviewing files that changed from the base of the PR and between 02b64bc and 00b5b67.

📒 Files selected for processing (4)
  • .github/workflows/_example_tests_runner.yml
  • .github/workflows/gpu_tests.yml
  • .github/workflows/regression_tests.yml
  • .github/workflows/unit_tests.yml

📝 Walkthrough

Walkthrough

The pull request updates Codecov coverage upload actions from v5 to v7 in four GitHub Actions workflows.

Changes

Coverage Upload Workflows

Layer / File(s) Summary
Update Codecov coverage uploads
.github/workflows/_example_tests_runner.yml, .github/workflows/gpu_tests.yml, .github/workflows/regression_tests.yml, .github/workflows/unit_tests.yml
The coverage upload steps now use codecov/codecov-action@v7 instead of @v5.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aanoosheh

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the Codecov action upgrade to v7 and the removal of the final Node.js 20 warning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security Anti-Patterns ✅ Passed The commit changes only four Codecov workflow YAML files; it adds no modelopt/examples Python code or security-sensitive patterns covered by this check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch kmorabia/bump-codecov-node24

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.08%. Comparing base (02b64bc) to head (00b5b67).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2110      +/-   ##
==========================================
- Coverage   78.60%   78.08%   -0.52%     
==========================================
  Files         522      522              
  Lines       60167    60167              
==========================================
- Hits        47294    46982     -312     
- Misses      12873    13185     +312     
Flag Coverage Δ
examples 42.93% <ø> (+1.06%) ⬆️
gpu 58.65% <ø> (-0.62%) ⬇️
regression 14.90% <ø> (+0.04%) ⬆️
unit 55.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kevalmorabia97
kevalmorabia97 merged commit 99116c3 into main Aug 7, 2026
54 checks passed
@kevalmorabia97
kevalmorabia97 deleted the kmorabia/bump-codecov-node24 branch August 7, 2026 13:01
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-07 13:01 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant