Bump codecov-action to v7, the last Node 20 warning - #2110
Conversation
#2102 and #2103 covered every action this repo references directly, but the warning persisted because codecov-action@v5 pulls in actions/github-script@60a0d830 (node20) internally. v6.0.2 and v7.0.0 both move to github-script@ed597411 (node24). v6's release notes call out node24 support as the only breaking aspect, matching the other bumps in #2102; our runners report 2.336.0. The inputs used here -- token, files, flags, fail_ci_if_error, verbose -- are all still present in v7. A scan of every referenced action, direct and one level transitive, now reports no remaining node20 runtimes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request updates Codecov coverage upload actions from v5 to v7 in four GitHub Actions workflows. ChangesCoverage Upload Workflows
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
==========================================
- Coverage 78.60% 78.08% -0.52%
==========================================
Files 522 522
Lines 60167 60167
==========================================
- Hits 47294 46982 -312
- Misses 12873 13185 +312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
What does this PR do?
Type of change: CI/CD maintenance
#2102 and #2103 bumped every action this repo references directly, but Node 20 annotations still appear — e.g. this run on #2103:
We never reference
github-script. It comes in transitively throughcodecov/codecov-action:@v5(= v5.5.5)60a0d830…@v6.0.2/@v7.0.0ed597411…Bumps all four call sites (
unit_tests,gpu_tests,regression_tests,_example_tests_runner) to@v7.Checked: v6's notes call out node24 support as the only breaking aspect — the same pattern as the bumps in #2102 — and our runners report 2.336.0. The inputs used here (
token,files,flags,fail_ci_if_error,verbose) all still exist in v7. A scan of every referenced action, direct and one level transitive, now finds no node20 runtimes left.Testing
Coverage upload runs in every unit, gpu, regression and example job, so CI exercises this broadly. Worth checking that coverage still lands in Codecov rather than only that the step is green —
fail_ci_if_error: falsemeans an upload failure would not turn the job red.Before your PR is "Ready for review"
CONTRIBUTING.md: N/ASummary by CodeRabbit