refactor(onboard): default runtime steps to record-only - #5687
Conversation
…rd-fsm-live-slice-inputs
…live-slice-inputs # Conflicts: # src/lib/onboard/machine/core-flow-phases.ts # src/lib/onboard/machine/final-flow-phases.ts # src/lib/onboard/machine/initial-flow-phases.ts # src/lib/onboard/machine/live-flow-slice.test.ts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in the Show a code coverage summary of the most covered files.
TypeScript / code-coverage/cliThe overall coverage in the Show a code coverage summary of the most covered files.
Updated |
PR Review Advisor — No blocking findingsMerge posture: No blocking advisor findings This is an automated, non-binding review; it still expects maintainers and agents to respond to each required or warning item. Treat suggestions as current-PR improvements when they touch changed code; defer only with maintainer rationale or a linked follow-up. A human maintainer must make the final merge decision. |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: Dispatch required Vitest E2E scenarios:
Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
…live-slice-inputs # Conflicts: # src/lib/onboard/machine/core-flow-phases.ts # src/lib/onboard/machine/initial-flow-phases.ts
…nboard-fsm-compat-result-loop
…onboard-fsm-drop-record-only-runner
…ctor/onboard-fsm-trim-recorders
…ard-fsm-record-only-boundary
…r/onboard-fsm-runtime-record-only
…nboard-fsm-compat-result-loop
## Summary Default `OnboardRuntime` step recording methods to record-only machine mutations. This moves the runtime closer to being the single source of machine transitions while preserving an explicit override for legacy tests and compatibility paths. ## Changes - Export shared `RECORD_ONLY_STEP_MUTATION_OPTIONS` from `onboard-step-mutation`. - Use the shared record-only default in `OnboardRuntime` and `OnboardRuntimeBoundary`. - Add runtime tests proving default step recording forwards record-only options while explicit overrides still work. ## Type of Change - [x] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [ ] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Verification - [x] PR description includes the DCO sign-off declaration and every commit appears as `Verified` in GitHub - [x] Git hooks passed during commit and push, or `npx prek run --from-ref main --to-ref HEAD` passes - [x] Targeted tests pass for changed behavior - [ ] Full `npm test` passes (broad runtime changes only) - [x] Tests added or updated for new or changed behavior - [x] No secrets, API keys, or credentials committed - [ ] Docs updated for user-facing behavior changes - [ ] `npm run docs` builds without warnings (doc changes only) - [ ] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) --- Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Default
OnboardRuntimestep recording methods to record-only machine mutations. This moves the runtime closer to being the single source of machine transitions while preserving an explicit override for legacy tests and compatibility paths.Changes
RECORD_ONLY_STEP_MUTATION_OPTIONSfromonboard-step-mutation.OnboardRuntimeandOnboardRuntimeBoundary.Type of Change
Verification
Verifiedin GitHubnpx prek run --from-ref main --to-ref HEADpassesnpm testpasses (broad runtime changes only)npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com