fix(e2e): load shared exit helper under tsx - #7027
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe live Vitest invocation tool now supports default and namespace exports from ChangesLive Vitest invocation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage remains at 96%, unchanged from the Code Coverage is in Public Preview. Learn more and provide us with your feedback. |
PR Review Advisor — InformationalAdvisor assessment: Informational / high confidence Model lanes
Nemotron output stays in workflow artifacts and does not change the assessment above. E2E guidanceAdvisory only. E2E / PR Gate selects and runs jobs independently. Recommended E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Summary
Restore live E2E execution through the workflow's
npx tsxcommand. The shared helper now loads the root CommonJS exit utility correctly instead of failing every converted live job during module initialization.Changes
src/lib/core/process-exit.tsintools/e2e/live-vitest-invocation.mts. The current consumer is the live E2E workflow introduced by refactor(e2e): route live-Vitest invocations through a validated helper #6996;tsxand Vitest expose the root module differently, so the existing repository interop pattern is required to keep one shared exit-code implementation.tsxexecutable thatnpx tsxresolves, protecting the production loader boundary that the previous native Node test did not exercise.Type of Change
Quality Gates
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run check:diffpassed when hooks were skipped or unavailablenpx vitest run --project e2e-support test/e2e/support/live-vitest-invocation.test.tspassed 24 tests;npm run typecheck:cliand Biome also passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — not applicable to this focused CI helper fix. The full E2E-support attempt reached five unrelated failures in an unchanged platform-parity shell script under macOS Bash 3.2; the other 41 tests in the diagnostic subset passed.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Charan Jagwani cjagwani@nvidia.com
Summary by CodeRabbit