Skip to content

test(images): align aiohttp capability union pin - #8233

Closed
cjagwani wants to merge 2 commits into
mainfrom
codex/fix-aiohttp-capability-union
Closed

test(images): align aiohttp capability union pin#8233
cjagwani wants to merge 2 commits into
mainfrom
codex/fix-aiohttp-capability-union

Conversation

@cjagwani

@cjagwani cjagwani commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Aligns the managed-image capability union test with the authoritative Hermes Teams dependency pin introduced on main. Before this change, the test still expected aiohttp==3.14.1; it now expects the shipped aiohttp==3.14.3 pin and stops failing unrelated pull requests.

Changes

  • Update both managed-image capability union expectations from aiohttp==3.14.1 to aiohttp==3.14.3.
  • Keep the test aligned with nemoclaw-blueprint/model-specific-setup/hermes/teams.json.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This changes stale test expectations only; the user-facing dependency documentation already identifies aiohttp==3.14.3.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: Reviewed test/managed-image-capability-union.test.ts, the authoritative Hermes Teams dependency manifest, and existing dependency documentation; no documentation files require changes.
  • Agent: Codex Desktop

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project integration test/managed-image-capability-union.test.ts (5 passed)
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — not applicable to two stale dependency-version expectations
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Charan Jagwani cjagwani@nvidia.com

Summary by CodeRabbit

  • Tests

    • Updated package compatibility checks to recognize aiohttp version 3.14.3.
    • Installation validation now reflects the latest supported package version, improving confidence in package setup and capability checks.
  • Chores

    • No user-facing functionality or public API changes were introduced.

Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 781e875f-1636-4ca3-b087-613055ac4656

📥 Commits

Reviewing files that changed from the base of the PR and between bef5d0b and 37cb0a7.

📒 Files selected for processing (1)
  • test/managed-image-capability-union.test.ts

📝 Walkthrough

Walkthrough

The test updates two Hermes aiohttp expectations from version 3.14.1 to 3.14.3. The changes cover the managed-image package union and pip installation trace assertions.

Changes

Hermes package expectations

Layer / File(s) Summary
Update aiohttp test expectations
test/managed-image-capability-union.test.ts
The package pin and pip installation trace assertions now expect aiohttp==3.14.3.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#8203: Updates the same Hermes aiohttp version and related installation expectations.

Suggested labels: bug-fix

Suggested reviewers: cv

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the test update to align the aiohttp capability union pin.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-aiohttp-capability-union

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 37cb0a7 in the codex/fix-aiohttp-ca... branch remains at 96%, unchanged from commit bef5d0b in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 37cb0a7 in the codex/fix-aiohttp-ca... branch remains at 81%, unchanged from commit bef5d0b in the main branch.

Show a code coverage summary of the most impacted files.
File main bef5d0b codex/fix-aiohttp-ca... 37cb0a7 +/-
src/lib/sandbox...rce-identity.ts 87% 87% 0%
src/lib/shields/index.ts 68% 68% 0%
src/lib/state/m...-acquisition.ts 75% 75% 0%
src/lib/domain/.../connect-env.ts 89% 97% +8%

Updated August 04, 2026 15:52 UTC

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Advisor assessment: Informational / low confidence
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions
Status: No actionable findings remain in the canonical review ledger.

Model lanes

  • GPT-5.6 Terra (primary): Completed · low confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Failed

Second-opinion terminology and E2E selections are advisory. They do not change the primary assessment or E2E / PR Gate.

E2E guidance

Advisory only. E2E / PR Gate selects and runs jobs independently.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@cjagwani

cjagwani commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Exact-head review status for 37cb0a7639da552d2cbb1ec29b5e7db3338f9339:

  • All code, test, security, DCO, documentation-receipt, and E2E checks completed successfully.
  • GPT-5.6 Terra primary advisor completed successfully.
  • Nemotron second-opinion failed on attempts 1 and 2 with the identical workflow/tool-protocol error: it emitted analysis before the required pr_review_read_terminology tool result completed. Neither attempt produced an actionable review finding.

The PR is now ready for CodeRabbit and human review. The repeated Nemotron failure remains visible and is not self-waived; a maintainer can accept that non-success or request a later workflow retry.

@senthilr-nv

Copy link
Copy Markdown
Collaborator

Thanks for the fix. The aiohttp 3.14.3 CVE remediation already landed for Hermes and Deep Agents in #8203, and these exact two capability-union test expectation updates already landed in #8213. Current main contains aiohttp 3.14.3 at both lines, so this PR is now redundant and can be closed.

@cjagwani
cjagwani requested a review from cv August 4, 2026 16:21
@prekshivyas prekshivyas closed this Aug 4, 2026
@prekshivyas

Copy link
Copy Markdown
Collaborator

redundant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants