docs(agents): point the preset example at presets that exist - #9543
Conversation
AGENTS.md told a contributor to follow the structure of `slack.yaml` and `discord.yaml` when adding a network policy preset. Commit d13ef62 moved both files to `src/lib/messaging/channels/<channel>/policy/<agent>.yaml`, so neither name resolves under `nemoclaw-blueprint/policies/presets/`. The stale examples direct a contributor back into the layout that commit removed. Name `github.yaml` and `brave.yaml` instead. Both exist in that directory today, and together they show the two endpoint forms the preset schema accepts. `CLAUDE.md` is a tracked symlink to `AGENTS.md`, so this single-file change also updates the guidance that `CLAUDE.md` serves. Signed-off-by: Udaya Tejas <udayatejas2004@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe contributor guidance now references ChangesPolicy guidance
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation change points contributors to existing preset examples without changing executable code, configuration, or runtime behavior; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — InformationalAdvisor assessment: Informational / low confidence Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Documentation writer review: PASSThe replacement examples are accurate and focused:
I found no documentation or writing blocker. The PR still needs an independent human approval and successful normal CI before merge. |
CI classification: review and workflow-owner decision requiredAll normal documentation, link, DCO, commit, security, and repository checks now pass. The primary PR Review Advisor completed at high confidence with no blockers, warnings, or suggestions. The second-opinion lane did not complete across its original run and two bounded retries. On the final attempt, it remained in dependency setup for about 40 minutes, was cancelled, and then reported its analysis package unavailable. It did not produce a code finding. I am not starting another retry. A workflow owner must decide how to repair that advisory lane. The one-line documentation change also still needs an independent human approval. The PR remains blocked; no check will be waived or bypassed. |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
<!-- markdownlint-disable MD041 --> ## Summary Add the canonical dated changelog entry required before planning the v0.0.112 release. The entry summarizes the 75 merged PRs in `v0.0.111..af56158`, links user-facing themes to published documentation routes, and links every included source PR. ## Changes - Add `docs/changelog/2026-08-20.mdx` with the exact `## v0.0.112` release heading and parser-safe MDX SPDX comment. - Cover managed local inference, onboarding and sandbox lifecycle recovery, messaging continuity, review and release automation, E2E qualification, dependency updates, and cumulative documentation catch-up. - Preserve the documentation skip list and supported-agent matrix; the release entry contains none of the blocked terms or excluded experimental surfaces. ### Source-to-doc mapping - #8620 -> `docs/changelog/2026-08-20.mdx`: Record the LangChain Deep Agents Code 0.1.55 update. - #9192 -> `docs/changelog/2026-08-20.mdx`: Record the OpenShell 0.0.106 update. - #9240 -> `docs/changelog/2026-08-20.mdx`: Record the cold base-image pull heartbeat. - #9412 -> `docs/changelog/2026-08-20.mdx`: Record voice context preservation across sequential turns. - #9483 -> `docs/changelog/2026-08-20.mdx`: Record Ollama model verification through the sandbox endpoint. - #9493 -> `docs/changelog/2026-08-20.mdx`: Record E2E cloud-check wiring coverage. - #9495 -> `docs/changelog/2026-08-20.mdx`: Record Model Router endpoint health validation. - #9534 -> `docs/changelog/2026-08-20.mdx`: Record default-sandbox resolution for tunnel status. - #9537 -> `docs/changelog/2026-08-20.mdx`: Record Linux AMD64 Muse and Lightning profiles. - #9543 -> `docs/changelog/2026-08-20.mdx`: Record corrected network-policy preset examples. - #9545 -> `docs/changelog/2026-08-20.mdx`: Record shared runtime-adapter port validation. - #9578 -> `docs/changelog/2026-08-20.mdx`: Record Portable network creation before host aliases. - #9589 -> `docs/changelog/2026-08-20.mdx`: Record running vLLM profile validation. - #9590 -> `docs/changelog/2026-08-20.mdx`: Record the two-turn atomic advisor review. - #9597 -> `docs/changelog/2026-08-20.mdx`: Record Portable uninstall without host-owned lifecycle resources. - #9605 -> `docs/changelog/2026-08-20.mdx`: Record release automation for an initially empty tag history. - #9607 -> `docs/changelog/2026-08-20.mdx`: Record credential retry navigation. - #9626 -> `docs/changelog/2026-08-20.mdx`: Record retirement of DeepSeek V4 Pro from the featured menu. - #9631 -> `docs/changelog/2026-08-20.mdx`: Record reduction-directed advisor design blockers. - #9632 -> `docs/changelog/2026-08-20.mdx`: Record Portable Ollama under Podman. - #9633 -> `docs/changelog/2026-08-20.mdx`: Record llama.cpp attachment without `/props` model aliases. - #9636 -> `docs/changelog/2026-08-20.mdx`: Record Docker authority independent of terminal state. - #9641 -> `docs/changelog/2026-08-20.mdx`: Record the separate Portable host-gateway subnet. - #9642 -> `docs/changelog/2026-08-20.mdx`: Record cumulative command documentation catch-up. - #9645 -> `docs/changelog/2026-08-20.mdx`: Record removal of completed advisor rollout compatibility. - #9647 -> `docs/changelog/2026-08-20.mdx`: Record diagnostics for OpenShell deletion handoffs. - #9650 -> `docs/changelog/2026-08-20.mdx`: Record OpenClaw pairing settlement after route changes. - #9652 -> `docs/changelog/2026-08-20.mdx`: Record repaired same-turn advisor submissions. - #9653 -> `docs/changelog/2026-08-20.mdx`: Record llama.cpp authority preservation on resume. - #9654 -> `docs/changelog/2026-08-20.mdx`: Record the schema-owned Microsoft Teams webhook field. - #9655 -> `docs/changelog/2026-08-20.mdx`: Record configured managed vLLM ports. - #9656 -> `docs/changelog/2026-08-20.mdx`: Record interrupted managed vLLM installation recovery. - #9660 -> `docs/changelog/2026-08-20.mdx`: Record catalog-owned vLLM profiles and refreshed llama.cpp pins. - #9663 -> `docs/changelog/2026-08-20.mdx`: Record attested LKG production-image requests. - #9664 -> `docs/changelog/2026-08-20.mdx`: Record corrected documented environment-variable handling. - #9665 -> `docs/changelog/2026-08-20.mdx`: Record retired gateway evidence validation. - #9666 -> `docs/changelog/2026-08-20.mdx`: Record Docker authority across terminal sessions. - #9667 -> `docs/changelog/2026-08-20.mdx`: Record contribution intake and product-decision guidance. - #9669 -> `docs/changelog/2026-08-20.mdx`: Record bounded DGX Spark llama.cpp request bodies. - #9670 -> `docs/changelog/2026-08-20.mdx`: Record managed llama.cpp bridge authentication. - #9671 -> `docs/changelog/2026-08-20.mdx`: Record gateway recreation after Docker network loss. - #9672 -> `docs/changelog/2026-08-20.mdx`: Record bounded WSL Ollama host probes. - #9674 -> `docs/changelog/2026-08-20.mdx`: Record cumulative inference and command documentation catch-up. - #9675 -> `docs/changelog/2026-08-20.mdx`: Record Muse Glimmer vLLM image revision handling. - #9676 -> `docs/changelog/2026-08-20.mdx`: Record the grouped CodeQL Actions update. - #9677 -> `docs/changelog/2026-08-20.mdx`: Record the actions/setup-go 7.0.0 update. - #9678 -> `docs/changelog/2026-08-20.mdx`: Record resumable failed llama.cpp cleanup. - #9681 -> `docs/changelog/2026-08-20.mdx`: Record Docker executable injection in the state-mutation harness. - #9683 -> `docs/changelog/2026-08-20.mdx`: Record Windows Docker path fixtures. - #9684 -> `docs/changelog/2026-08-20.mdx`: Record isolated macOS status subprocess cleanup. - #9686 -> `docs/changelog/2026-08-20.mdx`: Record managed-inference catalog compilation for Portable E2E. - #9687 -> `docs/changelog/2026-08-20.mdx`: Record cumulative uninstall documentation catch-up. - #9688 -> `docs/changelog/2026-08-20.mdx`: Record DCode model-selector loading through tsx. - #9689 -> `docs/changelog/2026-08-20.mdx`: Record bounded docs-parity process starts. - #9690 -> `docs/changelog/2026-08-20.mdx`: Record reduced advisor review protocol failures. - #9691 -> `docs/changelog/2026-08-20.mdx`: Record managed llama.cpp bridge cleanup coverage. - #9692 -> `docs/changelog/2026-08-20.mdx`: Record upstream credential rejection diagnostics. - #9693 -> `docs/changelog/2026-08-20.mdx`: Record cumulative managed vLLM documentation catch-up. - #9694 -> `docs/changelog/2026-08-20.mdx`: Record the pinned Portable rootless Podman runtime. - #9695 -> `docs/changelog/2026-08-20.mdx`: Record owned llama.cpp image publication. - #9697 -> `docs/changelog/2026-08-20.mdx`: Record Windows-host Ollama resume behavior. - #9699 -> `docs/changelog/2026-08-20.mdx`: Record the separate trusted Windows path oracle. - #9702 -> `docs/changelog/2026-08-20.mdx`: Record sandbox bridge cleanup coverage. - #9703 -> `docs/changelog/2026-08-20.mdx`: Record hardened Ollama installer downloads. - #9704 -> `docs/changelog/2026-08-20.mdx`: Record supervised dashboard recovery evidence. - #9706 -> `docs/changelog/2026-08-20.mdx`: Record reused model and reasoning health validation. - #9708 -> `docs/changelog/2026-08-20.mdx`: Record fixed local vLLM profile preservation. - #9711 -> `docs/changelog/2026-08-20.mdx`: Record local registry authority in E2E runs. - #9712 -> `docs/changelog/2026-08-20.mdx`: Record Hermes dashboard migration before gateway health. - #9720 -> `docs/changelog/2026-08-20.mdx`: Record default OpenClaw session admission during uninstall. - #9721 -> `docs/changelog/2026-08-20.mdx`: Record MCP credential republishing after policy binding. - #9722 -> `docs/changelog/2026-08-20.mdx`: Record provider republishing after Docker recreation. - #9724 -> `docs/changelog/2026-08-20.mdx`: Record reclamation of dead Shields lifecycle owners. - #9725 -> `docs/changelog/2026-08-20.mdx`: Record fail-closed unscripted onboarding prompts. - #9729 -> `docs/changelog/2026-08-20.mdx`: Record aligned sandbox launch forward ports. ## Type of Change - [ ] Code change (feature, bug fix, or refactor) - [ ] Code change with doc updates - [x] Doc only (prose changes, no code sample modifications) - [ ] Doc only (includes code sample changes) ## Quality Gates - [ ] Tests added or updated for changed behavior - [x] Existing tests cover changed behavior — justification: `test/changelog-docs.test.ts` validates the dated release-entry contract. - [ ] Tests not applicable — justification: - [ ] Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging) - [ ] Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification: - [ ] Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue: ## DGX Station Hardware Evidence - [ ] Tested on DGX Station - Tested commit: Not applicable; documentation-only change. - Station profile/scenario: Not applicable. - Result: Not applicable. - Supporting evidence: Not applicable. ## Verification - [x] PR description includes a `Signed-off-by:` line and every commit appears as `Verified` in GitHub - [x] Normal `pre-commit`, `commit-msg`, and `pre-push` hooks passed, or `npm run validate:pr` passed after refreshing `origin/main` when hooks were skipped or unavailable - [x] Targeted behavior tests pass for the current change set, or tests are marked not applicable above — `npx vitest run test/changelog-docs.test.ts` (7 passed). - [ ] Applicable broad gate passed — `npm test` for broad runtime/test-harness changes; `npm run check` for repo-wide validation/coverage changes — command/result: Not applicable to one prose-only changelog page. - [x] Quality Gates section completed with required justifications or waivers - [x] No secrets, API keys, or credentials committed - [ ] `npm run docs` builds without warnings (doc changes only) — passed with 0 errors and the 2 existing Fern warnings. - [x] Doc pages follow the [style guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md) (doc changes only) - [ ] New doc pages include SPDX header and frontmatter (new pages only) — the parser-safe MDX SPDX comment is present; native changelog pages intentionally do not use frontmatter. --- Signed-off-by: Charan Jagwani <cjagwani@nvidia.com> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Documentation** * Added release notes for v0.0.112. * Documented improvements to managed model runtimes, sandbox recovery, MCP and provider handling, messaging, Shields, and PR Review Advisor. * Added details on release provenance, end-to-end qualification, dependency updates, and documentation alignment. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Summary
AGENTS.mdtells a contributor to follow the structure ofslack.yamlanddiscord.yamlwhen adding a network policy preset. PR #6129 moved both files tosrc/lib/messaging/channels/<channel>/policy/<agent>.yaml, so neither name resolves undernemoclaw-blueprint/policies/presets/. This change names two presets that exist in that directory today.Related Issue
Fixes #9542
Changes
AGENTS.md:307— replace theslack.yamlanddiscord.yamlexamples withgithub.yamlandbrave.yaml.One line in, one line out. No abstraction, configuration, fallback, migration, or compatibility path is added.
The diff touches one file, not two.
CLAUDE.mdis a tracked symlink toAGENTS.md(mode120000, blob contentAGENTS.md), sogit diff --statreports1 file changed, 1 insertion(+), 1 deletion(-)even though bothAGENTS.mdandCLAUDE.mdserve the corrected text. The symlink blob is unchanged.Why the examples are stale
git log --oneline --diff-filter=D --allon both paths returns one commit:git show --name-status d13ef6236records both as renames:git ls-files nemoclaw-blueprint/policies/presets/ | grep -i 'slack\|discord'returns nothing onmain.The stale examples do more than fail to resolve. They direct a contributor adding a messaging-channel policy back into the directory that #6129 emptied of messaging policies.
CLAUDE.mdresolves to this file, so every agent session in this repository reads the guidance.Why
github.yamlandbrave.yamlBoth exist in the directory that the preceding line names.
brave.yamluses theprotocol: restendpoint form with aruleslist, which matches the structure the removedslack.yamlhad.github.yamluses theaccess: fullform with abinarieslist. The pair shows both endpoint shapes the preset schema accepts.Why no line was added for messaging-channel policies
src/lib/messaging/AGENTS.md:76already instructs a contributor to add or updatesrc/lib/messaging/channels/<channel>/policy/<agent>.yaml, andAGENTS.md:48already links that file.src/lib/policy/index.ts:112-115andschemas/policy-preset.schema.json:5state the same split in code. A second bullet here would repeat guidance the repository already owns elsewhere.AGENTS.md:306(nemoclaw-blueprint/policies/presets/) remains correct.scripts/validate-configs.mts:127reads that directory.Scope
I checked the rest of
AGENTS.mdfor the same class of drift: every backticked path-like token, everynpm runscript against bothpackage.jsonfiles, the Vitest project names, the commitlint type list, theengines.noderange, and the language column of the architecture table. Line 307 was the only stale reference, so this PR changes only that line.Type of Change
Quality Gates
git ls-files nemoclaw-blueprint/policies/presets/.Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailable —npm run validate:prexits 0. Every hook reportsPassed, includingCodebase growth guardrails,Repository checks,markdownlint-cli2,Source-shape test budget, andTypeScript (CLI). I also ranNEMOCLAW_GROWTH_BASE_REF=upstream/main npx prek run --from-ref upstream/main --to-ref HEADfor both thepre-commitandpre-pushstages (exit 0; the TypeScript hooks reportno files to check, which matches a one-line Markdown diff), andnpx commitlint --from upstream/main --to HEAD(exit 0).npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: not applicable; this PR changes no runtime, test-harness, validation, or coverage input.npm run docsbuilds without warnings (doc changes only) —npm run docsexits 0 and reportscheck-docs-published-routes: OK — 68 guarded page(s), native changelog links, and direct legacy redirectsandFound 0 errors and 2 warnings. Both warnings are pre-existing and unrelated to this change:Missing redirects check skipped: not authenticated(local run withoutFERN_TOKEN) and the light-mode accent contrast ratio in the Fern theme.AGENTS.mdis not an input to the docs build, anddocs/_build/is gitignored, so this change produces no generated-file churn.AGENTS.mdis repository guidance, not a page underdocs/.Net line change:
git diff --numstatreports1 1 AGENTS.md. Net zero lines.Signed-off-by: Udaya Tejas udayatejas2004@gmail.com
Summary by CodeRabbit