Skip to content

fix(agents): add confirmation gate to triage-issue batch mode#2239

Merged
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
rhuss:fix/triage-batch-confirmation
Jul 13, 2026
Merged

fix(agents): add confirmation gate to triage-issue batch mode#2239
TaylorMutch merged 1 commit into
NVIDIA:mainfrom
rhuss:fix/triage-batch-confirmation

Conversation

@rhuss

@rhuss rhuss commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a mandatory preview-and-confirm step to the triage-issue skill's batch mode before processing any issues
  • The agent must show the issue count and titles, then ask for explicit user confirmation before posting triage comments
  • Single-issue mode (triage issue #250) is unchanged

Related Issue

No existing issue. This addresses an operational incident where batch triage was accidentally invoked and posted 29 triage-agent comments on public issues that had to be manually cleaned up.

Changes

  • .agents/skills/triage-issue/SKILL.md: Replace the immediate-process batch flow with a three-step preview/confirm/process gate

Testing

  • Invoke triage issues and verify the skill presents a preview with issue count and titles before asking for confirmation
  • Verify single-issue triage issue #250 still works without any confirmation prompt

Checklist

  • Commit message follows conventional commits
  • DCO sign-off included
  • No unrelated changes

@rhuss rhuss requested review from a team, derekwaynecarr, maxamillion and mrunalp as code owners July 13, 2026 09:33
@copy-pr-bot

copy-pr-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Batch triage previously processed all state:triage-needed issues
immediately without any confirmation. This led to accidental
mass-commenting (29 triage comments on a public repo) when the
skill was invoked by mistake.

Add a mandatory preview-and-confirm step: the agent must show the
issue count and titles, then ask for explicit user confirmation
before posting any comments.

Single-issue mode is unchanged.

Assisted-By: 🤖 Claude Code
Signed-off-by: Roland Huß <rhuss@redhat.com>
@rhuss rhuss force-pushed the fix/triage-batch-confirmation branch from 8ade8e7 to 47a9199 Compare July 13, 2026 09:33
@TaylorMutch

Copy link
Copy Markdown
Collaborator

/ok to test 47a9199

@TaylorMutch TaylorMutch enabled auto-merge (squash) July 13, 2026 15:50
@TaylorMutch TaylorMutch merged commit 0fe24a4 into NVIDIA:main Jul 13, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants