Skip to content

refactor(tui): default create form state - #2458

Merged
pimlock merged 1 commit into
mainfrom
codex/tui-form-defaults
Jul 24, 2026
Merged

refactor(tui): default create form state#2458
pimlock merged 1 commit into
mainfrom
codex/tui-form-defaults

Conversation

@elezar

@elezar elezar commented Jul 24, 2026

Copy link
Copy Markdown
Member

Summary

Add Default implementations for the TUI create-form state so modal openers only set dynamic data. This keeps future form fields centralized in the form defaults instead of repeated constructor literals.

Related Issue

N/A

Changes

  • Derived defaults for create-form focus and phase enums.
  • Derived defaults for CreateSandboxForm and CreateProviderForm.
  • Simplified create-form openers with struct update syntax.

Testing

  • /home/elezar/.cargo/bin/cargo fmt
  • /home/elezar/.cargo/bin/cargo test -p openshell-tui --lib passes
  • mise run pre-commit attempted, blocked in workspace Rust tasks by local z3-sys/z3.h header availability
  • E2E tests added/updated (not applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@elezar
elezar marked this pull request as ready for review July 24, 2026 09:08
@elezar

elezar commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

/ok-to-test d872bc7

@pimlock
pimlock added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 850bd42 Jul 24, 2026
31 checks passed
@pimlock
pimlock deleted the codex/tui-form-defaults branch July 24, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants