feat(k8s): support configuring workspace PVC storageClassName#2463
Open
loveRhythm1990 wants to merge 1 commit into
Open
feat(k8s): support configuring workspace PVC storageClassName#2463loveRhythm1990 wants to merge 1 commit into
loveRhythm1990 wants to merge 1 commit into
Conversation
loveRhythm1990
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
July 24, 2026 11:03
The Kubernetes driver's default workspace PVC never set storageClassName, so on clusters with no default StorageClass the PVC stayed Pending and sandbox creation failed. Add a workspace_storage_class option to KubernetesComputeConfig, wired through SandboxPodParams into the generated volumeClaimTemplates. When non-empty it sets storageClassName; empty preserves the current behavior of relying on the cluster default StorageClass. Expose it via the OPENSHELL_K8S_WORKSPACE_STORAGE_CLASS env var on both the standalone driver and the embedded gateway runtime defaults, and via the server.workspaceStorageClass Helm value. Closes NVIDIA#2442 Signed-off-by: lr90 <qiuweimin@matrixorigin.cn>
loveRhythm1990
force-pushed
the
lr90/k8s-workspace-storage-class
branch
from
July 24, 2026 11:45
17a15d8 to
9a705b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Kubernetes compute driver's default workspace PVC never set
storageClassName, so on clusters with no defaultStorageClassthe PVC stayedPendingand sandbox creation failed. This adds a driver-levelworkspace_storage_classoption so operators can pin the workspace PVC to a specificStorageClass.Related Issue
Closes #2442
Changes
workspace_storage_class: StringtoKubernetesComputeConfig(empty default preserves current behavior — omitstorageClassName, use the cluster defaultStorageClass).SandboxPodParamsintodefault_workspace_volume_claim_templates(), settingstorageClassNameon the generated PVC only when non-empty.OPENSHELL_K8S_WORKSPACE_STORAGE_CLASSin the standalone drivermain.rs, mirroring the existing storage-size env var.server.workspaceStorageClassin the Helm chart (values.yaml+gateway-config.yaml), regenerate the chartREADME.mdvia helm-docs.docs/reference/gateway-config.mdxanddocs/reference/sandbox-compute-drivers.mdx.debug-openshell-clusterskill.No proto/gRPC change — this is a driver-level default at the same granularity as the existing
workspace_default_storage_size.Testing
mise run pre-commitpasses (one pre-existing, unrelated failure inopenshell-supervisor-network::test_forward_public_ip_allowed_without_allowed_ips— an environment DNS-interception flake that also fails on cleanmain; untouched crate)storageClassNameset when provided and omitted when empty (driver.rs), plus config default/serde-override (config.rs)helm templaterendering both with and without the value setChecklist