Skip to content

fix(cli): continue multi-item deletes after failures - #3111

Merged
johntmyers merged 1 commit into
NVIDIA:mainfrom
grs:robust-multi-delete
Sep 1, 2026
Merged

fix(cli): continue multi-item deletes after failures#3111
johntmyers merged 1 commit into
NVIDIA:mainfrom
grs:robust-multi-delete

Conversation

@grs

@grs grs commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

CLI delete commands that accept multiple targets (sandbox delete, provider delete, provider profile delete) previously aborted on the first failing entry, leaving the remaining requested items untouched. This makes multi-item deletes fail-soft: each entry is attempted, per-item failures are reported to stderr as they happen, and the command exits with a single aggregated error once every requested deletion has been attempted.

Related Issue

Fixes #3102

Changes

  • sandbox_delete, provider_delete, and provider_profile_delete now collect per-item failures and continue instead of returning on the first error. Each failure is printed to stderr; the aggregated error is returned at the end.
  • documentation updated to include example of multi-delete and describe the fail-soft behaviour

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Signed-off-by: Gordon Sim <gsim@redhat.com>
@grs
grs requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners September 1, 2026 21:07
@copy-pr-bot

copy-pr-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@johntmyers johntmyers self-assigned this Sep 1, 2026

@johntmyers johntmyers left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gator-agent

PR Review Status

This focused CLI fix matches accepted issue #3102: all requested sandbox, provider, and provider-profile deletions are attempted, failures are aggregated, and the user-facing behavior is documented. The initial code-only review found no blocking defects.

Blocking findings:

  • No blocking findings remain

Carried findings:

  • None

Non-blocking suggestions:

  • None
Gator metadata
  • Validation: Project-valid because it implements accepted issue #3102 as a concentrated CLI correctness fix.
  • Docs: Relevant Fern pages under docs/ document the multi-delete behavior; navigation changes are not needed because the existing pages remain in place.
  • Checks: Current-head Branch Checks and Helm Lint are not yet dispatched; DCO and vouch are green.
  • E2E: test:e2e is required because sandbox deletion lifecycle behavior changes; dispatch is pending.
  • Head SHA: 1cdf6c5f1a8fbb89beccccda8738d35e693ddfe7
  • Base SHA: 5b925dd8afba6ba558e93803656e680b744769d7
  • Merge base SHA: 5b925dd8afba6ba558e93803656e680b744769d7
  • Patch ID: f6cfeb69a92205f1e408605063a995f9e9cf26f3
  • Gator payload: 8
  • Review mode: initial
  • Previous reviewed SHA: none
  • Review budget exhausted: no
  • Maintainer decision required: no
  • Next state: gator:in-review

@johntmyers johntmyers added gator:in-review Gator is reviewing or awaiting PR review feedback test:e2e Requires end-to-end coverage labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Label test:e2e applied, but pull-request/3111 does not exist yet. A maintainer needs to comment /ok to test 1cdf6c5f1a8fbb89beccccda8738d35e693ddfe7 to mirror this PR. Once the mirror exists, re-apply the label or re-run Branch E2E Checks from the Actions tab.

@johntmyers

Copy link
Copy Markdown
Collaborator

/ok to test 1cdf6c5

@johntmyers johntmyers added gator:watch-pipeline Gator is monitoring PR CI/CD status gator:approval-needed Gator completed review; maintainer approval needed and removed gator:in-review Gator is reviewing or awaiting PR review feedback gator:watch-pipeline Gator is monitoring PR CI/CD status labels Sep 1, 2026
@johntmyers
johntmyers added this pull request to the merge queue Sep 1, 2026
Merged via the queue into NVIDIA:main with commit 7b64c5c Sep 1, 2026
84 of 87 checks passed
@johntmyers johntmyers added gator:merge-ready and removed gator:approval-needed Gator completed review; maintainer approval needed labels Sep 1, 2026
@johntmyers

Copy link
Copy Markdown
Collaborator

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: the current head was reviewed with no blocking findings, required checks including E2E passed, and maintainer approval was present before merge.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

Gator metadata
  • Head SHA: 1cdf6c5f1a8fbb89beccccda8738d35e693ddfe7
  • Gator payload: 8
  • Final state: merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): more robust handling of multiple deletions

2 participants