fix(cli): continue multi-item deletes after failures - #3111
Conversation
Signed-off-by: Gordon Sim <gsim@redhat.com>
johntmyers
left a comment
There was a problem hiding this comment.
gator-agent
PR Review Status
This focused CLI fix matches accepted issue #3102: all requested sandbox, provider, and provider-profile deletions are attempted, failures are aggregated, and the user-facing behavior is documented. The initial code-only review found no blocking defects.
Blocking findings:
- No blocking findings remain
Carried findings:
- None
Non-blocking suggestions:
- None
Gator metadata
- Validation: Project-valid because it implements accepted issue #3102 as a concentrated CLI correctness fix.
- Docs: Relevant Fern pages under
docs/document the multi-delete behavior; navigation changes are not needed because the existing pages remain in place. - Checks: Current-head Branch Checks and Helm Lint are not yet dispatched; DCO and vouch are green.
- E2E:
test:e2eis required because sandbox deletion lifecycle behavior changes; dispatch is pending. - Head SHA:
1cdf6c5f1a8fbb89beccccda8738d35e693ddfe7 - Base SHA:
5b925dd8afba6ba558e93803656e680b744769d7 - Merge base SHA:
5b925dd8afba6ba558e93803656e680b744769d7 - Patch ID:
f6cfeb69a92205f1e408605063a995f9e9cf26f3 - Gator payload:
8 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
|
Label |
|
/ok to test 1cdf6c5 |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: the current head was reviewed with no blocking findings, required checks including E2E passed, and maintainer approval was present before merge. I removed the active Gator metadata
|
Summary
CLI delete commands that accept multiple targets (sandbox delete, provider delete, provider profile delete) previously aborted on the first failing entry, leaving the remaining requested items untouched. This makes multi-item deletes fail-soft: each entry is attempted, per-item failures are reported to stderr as they happen, and the command exits with a single aggregated error once every requested deletion has been attempted.
Related Issue
Fixes #3102
Changes
Testing
mise run pre-commitpassesChecklist