test(e2e): keep lifecycle sandboxes running - #3128
Merged
Merged
Conversation
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 2, 2026 13:31
|
Label |
elezar
force-pushed
the
codex/test-durable-e2e-mains
branch
from
September 2, 2026 13:40
9330f6f to
955f866
Compare
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
codex/test-durable-e2e-mains
branch
from
September 2, 2026 14:05
955f866 to
dd38f93
Compare
elezar
enabled auto-merge
September 2, 2026 14:11
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
8 tasks
drew
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align lifecycle-related E2E tests with the canonical-main, retained terminal-state, and ephemeral cleanup contracts. Use explicit durable mains where tests need a running sandbox, and make tests exercise the intended create semantics instead of silently converting lifecycle flags into scratch-plus-exec behavior.
Related Issue
No issue required: focused test maintenance correcting E2E lifecycle assumptions.
The production stale-exit race exposed by the stop/start test is addressed separately by #3132.
Changes
CompletedandErrorstates.--no-keepexit propagation followed by automatic deletion.--no-keepin the persistent scratch helper and remove misleading callers.Testing
mise run pre-commitpassescargo test --manifest-path e2e/rust/Cargo.toml --all-features --no-runmise run e2e:mechanistic-smokeContainerExitedrace fixed by fix(compute): fence stale container exits during start #3132Checklist