Skip to content

refactor(supervisor): make managed child ownership structural - #3156

Open
elezar wants to merge 2 commits into
codex/fix-detached-fast-exitfrom
3154-managed-child-ownership/elezar
Open

refactor(supervisor): make managed child ownership structural#3156
elezar wants to merge 2 commits into
codex/fix-detached-fast-exitfrom
3154-managed-child-ownership/elezar

Conversation

@elezar

@elezar elezar commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

Make supervisor child lifecycle ownership structural on every platform. Linux orphan-reaper registration remains internal to the wrapper; process and SSH callers share one managed Tokio/std child API.

Related Issue

Depends on #3142.

Closes #3154

Changes

  • Introduce a cross-platform ManagedChild<C> wrapper with private raw-child ownership.
  • Centralize wait, try_wait, drop cleanup, and ECHILD diagnostics.
  • Migrate canonical-process and SSH child spawning to the wrapper, with narrow stdio extraction methods.
  • Add std and Tokio lifecycle coverage that runs on every platform; retain Linux-only reaper-race coverage.

Testing

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

Closes #3154

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant