refactor(supervisor): make managed child ownership structural - #3156
Open
elezar wants to merge 2 commits into
Open
refactor(supervisor): make managed child ownership structural#3156elezar wants to merge 2 commits into
elezar wants to merge 2 commits into
Conversation
Closes #3154 Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 3, 2026 13:28
5 tasks
Signed-off-by: Evan Lezar <elezar@nvidia.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make supervisor child lifecycle ownership structural on every platform. Linux orphan-reaper registration remains internal to the wrapper; process and SSH callers share one managed Tokio/std child API.
Related Issue
Depends on #3142.
Closes #3154
Changes
ManagedChild<C>wrapper with private raw-child ownership.try_wait, drop cleanup, andECHILDdiagnostics.Testing
mise run pre-commitpassescargo test -p openshell-supervisor-process)Checklist